<div dir="ltr"><div>Looks good to me. Tapani (CCd) would know wheter we want EXEC_OBJECT_ASYNC or not. Either way (not setting EXEC_OBJECT_ASYNC won't hurt),</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>></div><div><br></div><div>Sorry for the mess and thanks for fixing it!</div><div><br></div><div>--Jason</div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jun 3, 2018 at 5:38 PM, Mauro Rossi <span dir="ltr"><<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Changes to avoid building error:<br>
<br>
external/mesa/src/intel/<wbr>vulkan/anv_android.c:131:72:<br>
error: too few arguments to function call, expected 5, have 4<br>
result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo);<br>
~~~~~~~~~~~~~~~~~~~ ^<br>
1 error generated.<br>
<br>
(v2) Set the correct bo_flags based on support of 48bit addresses and soft-pin<br>
<br>
Fixes: b0d50247a7 ("anv/allocator: Set the BO flags in bo_cache_alloc/import")<br>
Fixes: e7d0378bd9 ("anv: Soft-pin client-allocated memory")<br>
Signed-off-by: Mauro Rossi <<a href="mailto:issor.oruam@gmail.com">issor.oruam@gmail.com</a>><br>
---<br>
src/intel/vulkan/anv_android.c | 8 +++++++-<br>
1 file changed, 7 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_<wbr>android.c b/src/intel/vulkan/anv_<wbr>android.c<br>
</span>index 7e07dbaaa4..8611e77b82 100644<br>
<div class="HOEnZb"><div class="h5">--- a/src/intel/vulkan/anv_<wbr>android.c<br>
+++ b/src/intel/vulkan/anv_<wbr>android.c<br>
@@ -128,7 +128,13 @@ anv_image_from_gralloc(<wbr>VkDevice device_h,<br>
*/<br>
int dma_buf = gralloc_info->handle->data[0];<br>
<br>
- result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, &bo);<br>
+ uint64_t bo_flags = 0;<br>
+ if (device->instance-><wbr>physicalDevice.supports_48bit_<wbr>addresses)<br>
+ bo_flags |= EXEC_OBJECT_SUPPORTS_48B_<wbr>ADDRESS;<br>
+ if (device->instance-><wbr>physicalDevice.use_softpin)<br>
+ bo_flags |= EXEC_OBJECT_PINNED;<br>
+<br>
+ result = anv_bo_cache_import(device, &device->bo_cache, dma_buf, bo_flags, &bo);<br>
if (result != VK_SUCCESS) {<br>
return vk_errorf(device->instance, device, result,<br>
"failed to import dma-buf from VkNativeBufferANDROID");<br>
-- <br>
2.17.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div></div>