<div dir="ltr">I have updated my wip/nir-deref-instr branch with the recommended changes. I haven't actually squashed any fixup commits yet because I want to make sure everyone is happy with them before I do. </div><div class="gmail_extra"> <div class="gmail_quote">On Sun, Jun 3, 2018 at 4:10 PM, Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl" target="_blank">bas@basnieuwenhuizen.nl</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">These are some fixes for v4 of Jasons deref instruction series. Furthermore patches 107-119: radv: Remove image_var stores. radv: Use deref instructions for tex derefs in meta shaders. radeonsi: Add deref support to the nir scan pass. ac/nir: Add deref interp support. ac/nir: Add shared atomic deref instr support. radv: Gather info for deref instr based load/store. ac/nir: Add deref based var loads/stores. radv: Add shader info support for image deref instructions. ac/nir: Add deref support to image intrinsics. ac/nir: Implement derefs for integer gather4 lowering. ac/nir: Support deref instructions in tex instructions. ac/nir: Support deref instructions in get_sampler_desc. ac/nir: Implement the deref instr for shared memory. have to be moved to directly before patch 54 ("anv/pipeline: Do less deref instruction lowering"). With that the series has no regressions and should be fully bisectable without regressions on radv. _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>