<html><head></head><body>Yeah, Scott and I thought that went to the list before I did an offer the shoulder review, then realized it didn't after pushing. <div class="gmail_quote">On June 6, 2018 10:31:38 AM PDT, Eric Anholt <eric@anholt.net> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <pre class="k9mail">Eric Engestrom <eric.engestrom@intel.com> writes: <blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> On MacOS, the build fails because of a compiler complaint about a downcast: vma_random_test.cpp:239:18: error: non-constant-expression cannot be narrowed from type 'unsigned long' to 'uint_fast32_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing] random_test r{seed}; ^~~~ vma_random_test.cpp:239:18: note: insert an explicit cast to silence this issue random_test r{seed}; ^~~~ static_cast<uint_fast32_t>( ) Let's take the compiler's suggestion, as we only needed a long here to use strtoul(). Cc: Scott D Phillips <scott.d.phillips@intel.com> Signed-off-by: Eric Engestrom <eric.engestrom@intel.com> </blockquote> This commit seems to have resolved the issue: commit 08535dd8860951ce4572cd2590e417a1f3d96b3d Author: Scott D Phillips <scott.d.phillips@intel.com> Date: Tue Jun 5 09:29:43 2018 -0700 util/tests/vma: Fix warning c++11-narrowing </pre></blockquote></div></body></html>