<div dir="ltr"><div>It might be good to add some additional commentary in the commit message such as:</div><div><br></div><div>i965 advertises the 16-bit R and RG formats through eglQueryDmaBufFormatsEXT but falls over when a client tries to use or asks more information about such a format because driImageFormatToGLFormat returns MESA_FORMAT_NONE.<br></div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>></div><div><br></div><div>Let's use this instead of patch 5/7 from the series I sent earlier.  I'm still not sure I believe Daniel but advertising them shouldn't hurt.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 6, 2018 at 10:36 AM, Lionel Landwerlin <span dir="ltr"><<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Found by Eero.<br>
<br>
v2: Add G16R16 formats (Lionel)<br>
<br>
</span>v3: Fix G16R16 mapping to mesa format (Jason)<br>
<br>
Signed-off-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a><wbr>><br>
Reviewed-by: Plamena Manolova <<a href="mailto:plamena.manolova@intel.com">plamena.manolova@intel.com</a>> (v2)<br>
<span class="">Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=106642" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=106642</a><br>
---<br>
 src/mesa/drivers/dri/common/<wbr>dri_util.c | 16 ++++++++++++++++<br>
 1 file changed, 16 insertions(+)<br>
<br>
diff --git a/src/mesa/drivers/dri/common/<wbr>dri_util.c b/src/mesa/drivers/dri/common/<wbr>dri_util.c<br>
</span>index a591dfcd7d2..d257cb644c8 100644<br>
<span class="">--- a/src/mesa/drivers/dri/common/<wbr>dri_util.c<br>
+++ b/src/mesa/drivers/dri/common/<wbr>dri_util.c<br>
@@ -936,6 +936,22 @@ static const struct {<br>
       .image_format = __DRI_IMAGE_FORMAT_SARGB8,<br>
       .mesa_format  =        MESA_FORMAT_B8G8R8A8_SRGB,<br>
    },<br>
+   {<br>
+      .image_format = __DRI_IMAGE_FORMAT_R16,<br>
+      .mesa_format  =        MESA_FORMAT_R_UNORM16,<br>
+   },<br>
+   {<br>
+      .image_format = __DRI_IMAGE_FORMAT_R16,<br>
+      .mesa_format  =        MESA_FORMAT_L_UNORM16,<br>
+   },<br>
+   {<br>
+      .image_format = __DRI_IMAGE_FORMAT_GR1616,<br>
</span>+      .mesa_format  =        MESA_FORMAT_R16G16_UNORM,<br>
<div class="HOEnZb"><div class="h5">+   },<br>
+   {<br>
+      .image_format = __DRI_IMAGE_FORMAT_GR1616,<br>
+      .mesa_format  =        MESA_FORMAT_L16A16_UNORM,<br>
+   },<br>
 };<br>
<br>
 uint32_t<br>
-- <br>
2.17.1<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div>