<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - GLSL IR copy propagates loads of SSBOs" href="https://bugs.freedesktop.org/show_bug.cgi?id=106774#c15">Comment # 15</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - GLSL IR copy propagates loads of SSBOs" href="https://bugs.freedesktop.org/show_bug.cgi?id=106774">bug 106774</a> from <a class="email" href="mailto:jason@jlekstrand.net" title="Jason Ekstrand <jason@jlekstrand.net>"> Jason Ekstrand</a> <pre>(In reply to Michel Dänzer from <a href="show_bug.cgi?id=106774#c10">comment #10</a>) > (In reply to Jason Ekstrand from <a href="show_bug.cgi?id=106774#c9">comment #9</a>) > > > > I'm not sure if you looked at it, but it is a piglit shader_runner test. > > > > The current failure mode is many (recoverable) GPU hangs. > > > > I figured. What other kind of simple shader test is there? That was more > > of a "Once you fix it, please commit to piglit". > > Please don't add piglit tests which are expected to hang the GPU, or at > least don't set them up to be run by default. Not all drivers can reliably > recover from GPU hangs. The intention is not to add a test that hangs. The two required fixes are to the test and GLSL IR. Once those are made, it shouldn't hang for anyone. As far as general policy goes, no we don't want to have GPU hangs. Maybe we could even go so far to say that if you have a test which has a high probability of hanging the GPU, it shouldn't be added to the test list by default. However there are many kinds of tests which might hang the GPU if the driver has a bug as no fault of the test. As someone who works on a very hangy GPU, I'm keenly aware of this. :-) That doesn't mean we shouldn't land those tests; it means we should fix those drivers.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>