<div dir="ltr"><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></div><div><br></div><div>Marek</div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 5, 2018 at 7:58 AM, Gert Wollny <span dir="ltr"><<a href="mailto:gert.wollny@collabora.com" target="_blank">gert.wollny@collabora.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This warning is misleading: When a struct is partially initialized without<br>
assigning to the structure members by name, then the remaining fields<br>
will be zeroed out, and this warning will be issued (if enabled). If, on the<br>
other hand, the partial initialization is done by assigning to named members,<br>
the remaining structure elements may hold random data, but the warning is not<br>
issued. Since in Mesa the first approach to initialize structure elements is<br>
used very often, and it is usually assumed that the remaining elements are<br>
zeroed out, heeding this warning would be counter-productive.<br>
<br>
Signed-off-by: Gert Wollny <<a href="mailto:gert.wollny@collabora.com">gert.wollny@collabora.com</a>><br>
---<br>
<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
index 02dca4547c..7d71e0ee4e 100644<br>
--- a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
+++ b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
@@ -301,7 +301,9 @@ AX_CHECK_COMPILE_FLAG([-Wall], [CFLAGS="$CFLAGS<br>
AX_CHECK_COMPILE_FLAG([-<wbr>Werror=implicit-function-<wbr>declaration], [CFLAGS="$CFLAGS -Werror=implicit-function-<wbr>declaration"])<br>
AX_CHECK_COMPILE_FLAG([-<wbr>Werror=missing-prototypes], [CFLAGS="$CFLAGS -Werror=missing-prototypes"])<br>
AX_CHECK_COMPILE_FLAG([-<wbr>Wmissing-prototypes], [CFLAGS="$CFLAGS -Wmissing-prototypes"])<br>
+AX_CHECK_COMPILE_FLAG([-Wno-<wbr>missing-field-initializers], [CFLAGS="$CFLAGS -Wno-missing-field-<wbr>initializers"])<br>
AX_CHECK_COMPILE_FLAG([-fno-<wbr>math-errno], [CFLAGS="$CFLAGS -fno-math-errno"])<br>
+<br>
AX_CHECK_COMPILE_FLAG([-fno-<wbr>trapping-math], [CFLAGS="$CFLAGS -fno-trapping-math"])<br>
AX_CHECK_COMPILE_FLAG([-<wbr>fvisibility=hidden], [VISIBILITY_CFLAGS="-<wbr>fvisibility=hidden"])<br>
<span class="HOEnZb"><font color="#888888"> <br>
-- <br>
2.16.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>