<div dir="ltr"><div>Yes, please. :-) Patches 3-6 are,</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo <span dir="ltr"><<a href="mailto:jmcasanova@igalia.com" target="_blank">jmcasanova@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
src/intel/compiler/brw_fs.h | 11 ------<br>
src/intel/compiler/brw_fs_nir.<wbr>cpp | 62 ------------------------------<wbr>-<br>
2 files changed, 73 deletions(-)<br>
<br>
diff --git a/src/intel/compiler/brw_fs.h b/src/intel/compiler/brw_fs.h<br>
index 779170ecc95..d72164ae0b6 100644<br>
--- a/src/intel/compiler/brw_fs.h<br>
+++ b/src/intel/compiler/brw_fs.h<br>
@@ -508,17 +508,6 @@ fs_reg shuffle_64bit_data_for_32bit_<wbr>write(const brw::fs_builder &bld,<br>
const fs_reg &src,<br>
uint32_t components);<br>
<br>
-void shuffle_32bit_load_result_to_<wbr>16bit_data(const brw::fs_builder &bld,<br>
- const fs_reg &dst,<br>
- const fs_reg &src,<br>
- uint32_t first_component,<br>
- uint32_t components);<br>
-<br>
-void shuffle_16bit_data_for_32bit_<wbr>write(const brw::fs_builder &bld,<br>
- const fs_reg &dst,<br>
- const fs_reg &src,<br>
- uint32_t components);<br>
-<br>
void shuffle_from_32bit_read(const brw::fs_builder &bld,<br>
const fs_reg &dst,<br>
const fs_reg &src,<br>
diff --git a/src/intel/compiler/brw_fs_<wbr>nir.cpp b/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
index a54935f7049..7e738ade82e 100644<br>
--- a/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
+++ b/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
@@ -5263,40 +5263,6 @@ shuffle_32bit_load_result_to_<wbr>64bit_data(const fs_builder &bld,<br>
}<br>
}<br>
<br>
-void<br>
-shuffle_32bit_load_result_to_<wbr>16bit_data(const fs_builder &bld,<br>
- const fs_reg &dst,<br>
- const fs_reg &src,<br>
- uint32_t first_component,<br>
- uint32_t components)<br>
-{<br>
- assert(type_sz(src.type) == 4);<br>
- assert(type_sz(dst.type) == 2);<br>
-<br>
- /* A temporary is used to un-shuffle the 32-bit data of each component in<br>
- * into a valid 16-bit vector. We can't write directly to dst because it<br>
- * can be the same register as src and in that case the first MOV in the<br>
- * loop below would overwrite the data read in the second MOV.<br>
- */<br>
- fs_reg tmp = retype(bld.vgrf(src.type), dst.type);<br>
-<br>
- for (unsigned i = 0; i < components; i++) {<br>
- const fs_reg component_i =<br>
- subscript(offset(src, bld, (first_component + i) / 2), dst.type,<br>
- (first_component + i) % 2);<br>
-<br>
- bld.MOV(offset(tmp, bld, i % 2), component_i);<br>
-<br>
- if (i % 2) {<br>
- bld.MOV(offset(dst, bld, i -1), offset(tmp, bld, 0));<br>
- bld.MOV(offset(dst, bld, i), offset(tmp, bld, 1));<br>
- }<br>
- }<br>
- if (components % 2) {<br>
- bld.MOV(offset(dst, bld, components - 1), tmp);<br>
- }<br>
-}<br>
-<br>
/**<br>
* This helper does the inverse operation of<br>
* SHUFFLE_32BIT_LOAD_RESULT_TO_<wbr>64BIT_DATA.<br>
@@ -5329,34 +5295,6 @@ shuffle_64bit_data_for_32bit_<wbr>write(const fs_builder &bld,<br>
return dst;<br>
}<br>
<br>
-void<br>
-shuffle_16bit_data_for_32bit_<wbr>write(const fs_builder &bld,<br>
- const fs_reg &dst,<br>
- const fs_reg &src,<br>
- uint32_t components)<br>
-{<br>
- assert(type_sz(src.type) == 2);<br>
- assert(type_sz(dst.type) == 4);<br>
-<br>
- /* A temporary is used to shuffle the 16-bit data of each component in the<br>
- * 32-bit data vector. We can't write directly to dst because it can be the<br>
- * same register as src and in that case the first MOV in the loop below<br>
- * would overwrite the data read in the second MOV.<br>
- */<br>
- fs_reg tmp = bld.vgrf(dst.type);<br>
-<br>
- for (unsigned i = 0; i < components; i++) {<br>
- const fs_reg component_i = offset(src, bld, i);<br>
- bld.MOV(subscript(tmp, src.type, i % 2), component_i);<br>
- if (i % 2) {<br>
- bld.MOV(offset(dst, bld, i / 2), tmp);<br>
- }<br>
- }<br>
- if (components % 2) {<br>
- bld.MOV(offset(dst, bld, components / 2), tmp);<br>
- }<br>
-}<br>
-<br>
/*<br>
* This helper takes a source register and un/shuffles it into the destination<br>
* register.<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.17.1<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>