<div dir="ltr"><div>12 and 14 are</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>></div><div><br></div><div>Thanks for working on this! This is very nice clean-up.</div><div><br></div><div>--Jason</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo <span dir="ltr"><<a href="mailto:jmcasanova@igalia.com" target="_blank">jmcasanova@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
src/intel/compiler/brw_fs.h | 4 ----<br>
src/intel/compiler/brw_fs_nir.<wbr>cpp | 32 ------------------------------<wbr>-<br>
2 files changed, 36 deletions(-)<br>
<br>
diff --git a/src/intel/compiler/brw_fs.h b/src/intel/compiler/brw_fs.h<br>
index 1f86f17ccbb..17b1368d522 100644<br>
--- a/src/intel/compiler/brw_fs.h<br>
+++ b/src/intel/compiler/brw_fs.h<br>
@@ -499,10 +499,6 @@ private:<br>
void *mem_ctx;<br>
};<br>
<br>
-fs_reg shuffle_64bit_data_for_32bit_<wbr>write(const brw::fs_builder &bld,<br>
- const fs_reg &src,<br>
- uint32_t components);<br>
-<br>
void shuffle_from_32bit_read(const brw::fs_builder &bld,<br>
const fs_reg &dst,<br>
const fs_reg &src,<br>
diff --git a/src/intel/compiler/brw_fs_<wbr>nir.cpp b/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
index 833fad4247a..f68fe5f1d1a 100644<br>
--- a/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
+++ b/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
@@ -5187,38 +5187,6 @@ fs_visitor::nir_emit_jump(<wbr>const fs_builder &bld, nir_jump_instr *instr)<br>
}<br>
}<br>
<br>
-/**<br>
- * This helper does the inverse operation of<br>
- * SHUFFLE_32BIT_LOAD_RESULT_TO_<wbr>64BIT_DATA.<br>
- *<br>
- * We need to do this when we are going to use untyped write messsages that<br>
- * operate with 32-bit components in order to arrange our 64-bit data to be<br>
- * in the expected layout.<br>
- *<br>
- * Notice that callers of this function, unlike in the case of the inverse<br>
- * operation, would typically need to call this with dst and src being<br>
- * different registers, since they would otherwise corrupt the original<br>
- * 64-bit data they are about to write. Because of this the function checks<br>
- * that the src and dst regions involved in the operation do not overlap.<br>
- */<br>
-fs_reg<br>
-shuffle_64bit_data_for_32bit_<wbr>write(const fs_builder &bld,<br>
- const fs_reg &src,<br>
- uint32_t components)<br>
-{<br>
- assert(type_sz(src.type) == 8);<br>
-<br>
- fs_reg dst = bld.vgrf(BRW_REGISTER_TYPE_D, 2 * components);<br>
-<br>
- for (unsigned i = 0; i < components; i++) {<br>
- const fs_reg component_i = offset(src, bld, i);<br>
- bld.MOV(offset(dst, bld, 2 * i), subscript(component_i, dst.type, 0));<br>
- bld.MOV(offset(dst, bld, 2 * i + 1), subscript(component_i, dst.type, 1));<br>
- }<br>
-<br>
- return dst;<br>
-}<br>
-<br>
/*<br>
* This helper takes a source register and un/shuffles it into the destination<br>
* register.<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.17.1<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>