<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo <span dir="ltr"><<a href="mailto:jmcasanova@igalia.com" target="_blank">jmcasanova@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">do_untyped_vector_read is used at load_ssbo and load_shared.<br>
<br>
The previous MOVs are removed because shuffle_from_32bit_read<br>
can handle storing the shuffle results in the expected destination<br>
just using the proper offset.<br>
---<br>
src/intel/compiler/brw_fs_nir.<wbr>cpp | 12 ++----------<br>
1 file changed, 2 insertions(+), 10 deletions(-)<br>
<br>
diff --git a/src/intel/compiler/brw_fs_<wbr>nir.cpp b/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
index 7e738ade82e..780a9e228de 100644<br>
--- a/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
+++ b/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
@@ -2434,16 +2434,8 @@ do_untyped_vector_read(const fs_builder &bld,<br>
BRW_PREDICATE_NONE);<br>
<br>
/* Shuffle the 32-bit load result into valid 64-bit data */<br>
- const fs_reg packed_result = bld.vgrf(dest.type, iter_components);<br>
- shuffle_32bit_load_result_to_<wbr>64bit_data(<br>
- bld, packed_result, read_result, iter_components);<br>
-<br>
- /* Move each component to its destination */<br>
- read_result = retype(read_result, BRW_REGISTER_TYPE_DF);<br>
- for (int c = 0; c < iter_components; c++) {<br>
- bld.MOV(offset(dest, bld, it * 2 + c),<br>
- offset(packed_result, bld, c));<br>
- }<br></blockquote><div><br></div><div>I really don't know why we needed this extra set of MOVs. They seem pretty pointless to me. Maybe history? In any case, this looks good.</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ shuffle_from_32bit_read(bld, offset(dest, bld, it * 2),<br>
+ read_result, 0, iter_components);<br>
<br>
bld.ADD(read_offset, read_offset, brw_imm_ud(16));<br>
}<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.17.1<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>