<div dir="ltr"><div>Makes sense.</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 29, 2018 at 12:07 AM, Samuel Iglesias Gonsálvez <span dir="ltr"><<a href="mailto:siglesias@igalia.com" target="_blank">siglesias@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If the application asks for the maximum number of fragment input<br>
components (128), use all of them plus some builtins that are<br>
passed in the VUE, then we exceed the maximum number of used VUE<br>
slots (32) and we break one assert that checks this limit.<br>
<br>
Also, with separate shader objects, we add CLIP_DIST0, CLIP_DIST1<br>
builtins in brw_compute_vue_map() because we don't know if<br>
gl_ClipDistance is going to be read/write by an adjacent stage.<br>
<br>
Fixes VK-GL-CTS CL#2569.<br>
<br>
Signed-off-by: Samuel Iglesias Gonsálvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>><br>
---<br>
src/intel/vulkan/anv_device.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_device.<wbr>c b/src/intel/vulkan/anv_device.<wbr>c<br>
index 374fc16c4c9..87c0d0cb4a6 100644<br>
--- a/src/intel/vulkan/anv_device.<wbr>c<br>
+++ b/src/intel/vulkan/anv_device.<wbr>c<br>
@@ -898,7 +898,7 @@ void anv_<wbr>GetPhysicalDeviceProperties(<br>
.maxGeometryOutputComponents = 128,<br>
.maxGeometryOutputVertices = 256,<br>
.<wbr>maxGeometryTotalOutputComponen<wbr>ts = 1024,<br>
- .maxFragmentInputComponents = 128,<br>
+ .maxFragmentInputComponents = 112, /* 128 components - (POS, PSIZ, CLIP_DIST0, CLIP_DIST1) */<br>
.maxFragmentOutputAttachments = 8,<br>
.maxFragmentDualSrcAttachments = 1,<br>
.<wbr>maxFragmentCombinedOutputResou<wbr>rces = 8,<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.17.0<br>
<br>
</font></span></blockquote></div><br></div>