<div dir="ltr"><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></div><div><br></div><div>Marek</div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 14, 2018 at 7:35 PM, Gurchetan Singh <span dir="ltr"><<a href="mailto:gurchetansingh@chromium.org" target="_blank">gurchetansingh@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We don't have cases for atomic types, some of which are explicitly<br>
signed or unsigned.<br>
<br>
The other opcodes could have uint or int return types, based on the<br>
sources.<br>
---<br>
src/gallium/auxiliary/tgsi/<wbr>tgsi_info.c | 5 +++++<br>
1 file changed, 5 insertions(+)<br>
<br>
diff --git a/src/gallium/auxiliary/tgsi/<wbr>tgsi_info.c b/src/gallium/auxiliary/tgsi/<wbr>tgsi_info.c<br>
index 4aa658785cf..6f3cd9c5304 100644<br>
--- a/src/gallium/auxiliary/tgsi/<wbr>tgsi_info.c<br>
+++ b/src/gallium/auxiliary/tgsi/<wbr>tgsi_info.c<br>
@@ -253,6 +253,9 @@ tgsi_opcode_infer_src_type(<wbr>enum tgsi_opcode opcode, uint src_idx)<br>
return TGSI_TYPE_SIGNED;<br>
<br>
switch (opcode) {<br>
+ case TGSI_OPCODE_ATOMUADD:<br>
+ case TGSI_OPCODE_ATOMUMAX:<br>
+ case TGSI_OPCODE_ATOMUMIN:<br>
case TGSI_OPCODE_UIF:<br>
case TGSI_OPCODE_TXF:<br>
case TGSI_OPCODE_TXF_LZ:<br>
@@ -268,6 +271,8 @@ tgsi_opcode_infer_src_type(<wbr>enum tgsi_opcode opcode, uint src_idx)<br>
case TGSI_OPCODE_U2I64:<br>
case TGSI_OPCODE_MEMBAR:<br>
return TGSI_TYPE_UNSIGNED;<br>
+ case TGSI_OPCODE_ATOMIMAX:<br>
+ case TGSI_OPCODE_ATOMIMIN:<br>
case TGSI_OPCODE_IMUL_HI:<br>
case TGSI_OPCODE_I2F:<br>
case TGSI_OPCODE_I2D:<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.13.5<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>