<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 2, 2018 at 2:19 PM, Kenneth Graunke <span dir="ltr"><<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is the wrong kind of dirty bit.  Caught by GCC warnings, due to<br>
64-bit values being truncated to 32 bits.<br>
<br>
Fixes: b95b0e2918c052068caeb4f6c2802b<wbr>a89be043a3 (intel/anv,blorp,i965: Implement the SKL 16x MSAA SIMD32 workaround)<br>
---<br>
 src/mesa/drivers/dri/i965/<wbr>genX_state_upload.c | 4 ++--<br>
 1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>genX_state_upload.c b/src/mesa/drivers/dri/i965/<wbr>genX_state_upload.c<br>
index b279f01e1a1..7fe12887030 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>genX_state_upload.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>genX_state_upload.c<br>
@@ -4073,13 +4073,13 @@ genX(upload_ps)(struct brw_context *brw)<br>
 static const struct brw_tracked_state genX(ps_state) = {<br>
    .dirty = {<br>
       .mesa  = _NEW_MULTISAMPLE |<br>
-               (GEN_GEN >= 9 ? BRW_NEW_NUM_SAMPLES : 0) |<br>
                (GEN_GEN < 8 ? _NEW_BUFFERS |<br>
                               _NEW_COLOR<br>
                             : 0),<br>
       .brw   = BRW_NEW_BATCH |<br>
                BRW_NEW_BLORP |<br>
-               BRW_NEW_FS_PROG_DATA,<br>
+               BRW_NEW_FS_PROG_DATA |<br>
+               (GEN_GEN >= 9 ? BRW_NEW_NUM_SAMPLES : 0),<br>
    },<br>
    .emit = genX(upload_ps),<br>
 };<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.18.0<br>
<br>
</font></span></blockquote></div><br></div>