<html>
    <head>
      <base href="https://bugs.freedesktop.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - GLSL disk cache: blob format changes may cause segfaults etc."
   href="https://bugs.freedesktop.org/show_bug.cgi?id=107096">107096</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>GLSL disk cache: blob format changes may cause segfaults etc.
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>Mesa
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>unspecified
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Other
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>glsl-compiler
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>mesa-dev@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>bugspam@moreofthesa.me.uk
          </td>
        </tr>

        <tr>
          <th>QA Contact</th>
          <td>intel-3d-bugs@lists.freedesktop.org
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Test case: “Deus Ex: Mankind Divided”. GPU is RX 470.

This was working fine with Mesa 18.1.1 installed but stopped working (symptom
was a strcmp() segfaulting due to one parameter being NULL) with 18.1.3
installed. I tested 18.1.2; that worked fine. (This game crashes on first run
after installing a different version of Mesa, but I'm not concerned with that
here.)

Clearing Steam's shader cache for this game and running with 18.1.3 works fine
(and the new cache content would, I expect, cause problems with 18.1.2 and
earlier).

I went looking for patches which messed with cache content and reverted one
which adds more data; with the original cached shaders, 18.1.3 suddenly started
working without problems.

The commit which I reverted is 915d9166bf4c “glsl: serialize data from
glTransformFeedbackVaryings”, which is commit ab2643e4b06f in master. I suspect
that 99c6cae22780 “glsl/cache: save and restore ExternalSamplersUsed” and other
such patches will cause similar breakage.

Changes to the on-disk shader cache format should cause a cache version bump.
This doesn't seem to be happening…</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>