<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests" href="https://bugs.freedesktop.org/show_bug.cgi?id=106644#c27">Comment # 27</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests" href="https://bugs.freedesktop.org/show_bug.cgi?id=106644">bug 106644</a> from <a class="email" href="mailto:sroland@vmware.com" title="Roland Scheidegger <sroland@vmware.com>"> Roland Scheidegger</a> <pre>(In reply to Ben Crocker from <a href="show_bug.cgi?id=106644#c25">comment #25</a>) > According to the Wikipedia article, the 970 is a Power ISA v2.03 (2002-2007) > CPU, > while VSX was not introduced until Power ISA v2.06 (February 2009) and > POWER7. > > So it seems to me that llc should recognize which version of the ISA each > CPU implements, and that it should disallow combinations like > -mcpu=970 -mattr=+altivec,+vsx I don't think you can blame llvm for that. This looks perfectly acceptable to me - you're specifying the cpu model (and that governs a lot more than just cpu extensions), but then specify some extensions on top of it. It's not llvm's fault that the cpu really can't do the extensions. (fwiw on x86 this is perfectly acceptable too, and it's even more weird there, for instance if you explicitly specify -avx but +f16c avx will get reenabled nevertheless, since the latter option actually requires avx (or more accurately, vex encoding) - you are responsible for specifying attributes which make sense.) Env vars to specify this are ok, but we should never manually enable attributes which the cpu can't support (and certainly not by default...). Surely it's possible to recognize these cpu features? Also, maybe llvm would recognize the availability of these features on its own nowadays correctly (as it does for x86)? Although I remember there were problems due to LE/BE differentation on ppc.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>