<div dir="ltr"><div>I've added my</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>></div><div><br></div><div>and pushed the patches.  Thanks, Ilia, for writing them and thanks, Yunchao, for rebasing them and finding the tests.</div><div><br></div><div>--Jason<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jul 20, 2018 at 5:16 PM Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for the changes, this series is :<br>
<br>
Reviewed-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>><br>
<br>
On 20/07/18 22:50, Yunchao He wrote:<br>
> From: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>><br>
><br>
> Allow the capability to be exposed, and convert the new execution mode<br>
> into fs state.<br>
><br>
> Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>><br>
> ---<br>
>   src/compiler/shader_info.h        | 1 +<br>
>   src/compiler/spirv/spirv_to_nir.c | 9 +++++++++<br>
>   2 files changed, 10 insertions(+)<br>
><br>
> diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h<br>
> index 3b95d5962c..e9ca222dea 100644<br>
> --- a/src/compiler/shader_info.h<br>
> +++ b/src/compiler/shader_info.h<br>
> @@ -59,6 +59,7 @@ struct spirv_supported_capabilities {<br>
>      bool stencil_export;<br>
>      bool atomic_storage;<br>
>      bool storage_8bit;<br>
> +   bool post_depth_coverage;<br>
>   };<br>
>   <br>
>   typedef struct shader_info {<br>
> diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c<br>
> index b92197b39b..7ac51a0107 100644<br>
> --- a/src/compiler/spirv/spirv_to_nir.c<br>
> +++ b/src/compiler/spirv/spirv_to_nir.c<br>
> @@ -3542,6 +3542,10 @@ vtn_handle_preamble_instruction(struct vtn_builder *b, SpvOp opcode,<br>
>            spv_check_supported(stencil_export, cap);<br>
>            break;<br>
>   <br>
> +      case SpvCapabilitySampleMaskPostDepthCoverage:<br>
> +         spv_check_supported(post_depth_coverage, cap);<br>
> +         break;<br>
> +<br>
>         default:<br>
>            vtn_fail("Unhandled capability");<br>
>         }<br>
> @@ -3609,6 +3613,11 @@ vtn_handle_execution_mode(struct vtn_builder *b, struct vtn_value *entry_point,<br>
>         b->shader->info.fs.early_fragment_tests = true;<br>
>         break;<br>
>   <br>
> +   case SpvExecutionModePostDepthCoverage:<br>
> +      vtn_assert(b->shader->info.stage == MESA_SHADER_FRAGMENT);<br>
> +      b->shader->info.fs.post_depth_coverage = true;<br>
> +      break;<br>
> +<br>
>      case SpvExecutionModeInvocations:<br>
>         vtn_assert(b->shader->info.stage == MESA_SHADER_GEOMETRY);<br>
>         b->shader->info.gs.invocations = MAX2(1, mode->literals[0]);<br>
<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>