<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Looks good.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">For series,</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Reviewed-by: Neha Bhende<bhenden@vmware.com><br>
</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<div id="Signature">
<div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255); font-family: Calibri, Arial, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<p>Regards,</p>
<p>Neha<br>
</p>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Brian Paul <brianp@vmware.com><br>
<b>Sent:</b> Friday, July 27, 2018 12:07:50 PM<br>
<b>To:</b> mesa-dev@lists.freedesktop.org<br>
<b>Cc:</b> Charmaine Lee; Neha Bhende<br>
<b>Subject:</b> [PATCH 2/2] swrast: fix crash in AA line code when there's no texture</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Fixes a crash running the Piglit polygon-mode-facing test (and<br>
probably others).<br>
---<br>
src/mesa/swrast/s_aalinetemp.h | 10 ++++++----<br>
1 file changed, 6 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/src/mesa/swrast/s_aalinetemp.h b/src/mesa/swrast/s_aalinetemp.h<br>
index bebb131..64767a3 100644<br>
--- a/src/mesa/swrast/s_aalinetemp.h<br>
+++ b/src/mesa/swrast/s_aalinetemp.h<br>
@@ -179,10 +179,12 @@ NAME(line)(struct gl_context *ctx, const SWvertex *v0, const SWvertex *v1)<br>
if (attr >= VARYING_SLOT_TEX0 && attr < VARYING_SLOT_VAR0) {<br>
const GLuint u = attr - VARYING_SLOT_TEX0;<br>
const struct gl_texture_object *obj = ctx->Texture.Unit[u]._Current;<br>
- const struct gl_texture_image *texImage =<br>
- _mesa_base_tex_image(obj);<br>
- line.texWidth[attr] = (GLfloat) texImage->Width;<br>
- line.texHeight[attr] = (GLfloat) texImage->Height;<br>
+ if (obj) {<br>
+ const struct gl_texture_image *texImage =<br>
+ _mesa_base_tex_image(obj);<br>
+ line.texWidth[attr] = (GLfloat) texImage->Width;<br>
+ line.texHeight[attr] = (GLfloat) texImage->Height;<br>
+ }<br>
}<br>
ATTRIB_LOOP_END<br>
}<br>
-- <br>
2.7.4<br>
<br>
</div>
</span></font></div>
</body>
</html>