<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 08/08/18 22:09, Rafael Antognolli
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20180808210945.2gppvhlurdsvnh7o@rantogno-mobl4.amr.corp.intel.com">
<blockquote type="cite" style="color: #000000;">
<pre wrap="">+ /* URB allocation */
+ hovered = _Hovered(mouse_pos, window_hovered, alloc_tl, alloc_br);
+ ImGui::ColorConvertHSVtoRGB((2 * s) * 1.0f / (2 * n_stages),
+ 1.0f, hovered ? 1.0f : 0.8f,
+ r, g, b);
+ draw_list->AddRectFilled(alloc_tl, alloc_br, ImColor(r, g, b));
+ if (hovered) {
+ ImGui::SetTooltip("%s: start=%u end=%u",
+ stage_names[s],
+ stages[s].start,
+ stages[s].n_entries * stages[s].size);
</pre>
</blockquote>
<pre wrap="">Maybe you should add stages[s].start to the "end" case? It seems
a little inconsistent right now.
Other than that, and taking into account how much I understand about
imgui, consider this:
Reviewed-by: Rafael Antognolli <a class="moz-txt-link-rfc2396E" href="mailto:rafael.antognolli@intel.com" moz-do-not-send="true"><rafael.antognolli@intel.com></a>
</pre>
</blockquote>
<p>Oh indeed, my bad!</p>
<p>-</p>
<p>Lionel<br>
</p>
</body>
</html>