<div dir="ltr">Hi Bas,<div><br><div class="gmail_quote"><div dir="ltr">Il giorno mar 14 ago 2018 alle ore 23:10 Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl">bas@basnieuwenhuizen.nl</a>> ha scritto:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Aug 14, 2018 at 10:48 PM, Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>> wrote:<br>
> (VkShaderModule) cast is added before NULL to avoid following building error:<br>
><br>
> external/mesa/src/amd/vulkan/radv_meta_decompress.c:365:54: error:<br>
> incompatible pointer to integer conversion passing 'void *' to parameter<br>
> of type 'VkShaderModule' (aka 'unsigned long long') [-Werror,-Wint-conversion]<br>
>                 VkResult ret = create_pipeline(cmd_buffer->device, NULL, samples,<br>
>                                                                    ^~~~<br>
> prebuilts/clang/host/linux-x86/clang-4053586/lib64/clang/5.0.300080/include/stddef.h:105:16:<br>
> note: expanded from macro 'NULL'<br>
> #  define NULL ((void*)0)<br>
>                ^~~~~~~~~~<br>
> external/mesa/src/amd/vulkan/radv_meta_decompress.c:97:32:<br>
> note: passing argument to parameter 'vs_module_h' here<br>
>                 VkShaderModule vs_module_h,<br>
>                                ^<br>
> 1 error generated.<br>
><br>
> Fixes: fbcd167314 ("radv: Add on-demand compilation of built-in shaders.")<br>
> Signed-off-by: Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>><br>
> ---<br>
>  src/amd/vulkan/radv_meta_decompress.c | 2 +-<br>
>  1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/src/amd/vulkan/radv_meta_decompress.c b/src/amd/vulkan/radv_meta_decompress.c<br>
> index 41ed7b6d04..183be1fd88 100644<br>
> --- a/src/amd/vulkan/radv_meta_decompress.c<br>
> +++ b/src/amd/vulkan/radv_meta_decompress.c<br>
> @@ -362,7 +362,7 @@ static void radv_process_depth_image_inplace(struct radv_cmd_buffer *cmd_buffer,<br>
>                 return;<br>
><br>
>         if (!meta_state->depth_decomp[samples_log2].decompress_pipeline) {<br>
> -               VkResult ret = create_pipeline(cmd_buffer->device, NULL, samples,<br>
> +               VkResult ret = create_pipeline(cmd_buffer->device, (VkShaderModule) NULL, samples,<br>
<br>
Instead of the cast, use VK_NULL_HANDLE.<br></blockquote><div><br></div><div>I've applied that change and it is working.</div><div><br></div><div>Do you prefer I send a v2 patch version to mesa-dev ML or may I apply to gitlab master with your Reviewed-by ?</div><div>Thanks<br></div><div><br></div><div>Mauro</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
>                                                meta_state->depth_decomp[samples_log2].pass,<br>
>                                                meta_state->depth_decomp[samples_log2].p_layout,<br>
>                                                &meta_state->depth_decomp[samples_log2].decompress_pipeline,<br>
> --<br>
> 2.17.1<br>
><br>
</blockquote></div></div></div>