<div dir="auto"><div>I admit to always being confused by depth, but:<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 22, 2018, 16:23 Sagar Ghuge <<a href="mailto:sagar.ghuge@intel.com">sagar.ghuge@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Gen >= 9 have ability to control clamping of depth values separately at<br>
near and far plane.<br>
<br>
z_w is clamped to the range [min(n,f), 0] if clamping at near plane is<br>
enabled, [0, max(n,f)] if clamping at far plane is enabled and [min(n,f)<br>
max(n,f)] if clamping at both plane is enabled.<br>
<br>
v2: 1) Use better coding style (Ian Romanick)<br>
<br>
Signed-off-by: Sagar Ghuge <<a href="mailto:sagar.ghuge@intel.com" target="_blank" rel="noreferrer">sagar.ghuge@intel.com</a>><br>
Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com" target="_blank" rel="noreferrer">ian.d.romanick@intel.com</a>><br>
---<br>
src/mesa/drivers/dri/i965/genX_state_upload.c | 20 ++++++++++++++-----<br>
1 file changed, 15 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c<br>
index dc54cb67af..b49c5839b5 100644<br>
--- a/src/mesa/drivers/dri/i965/genX_state_upload.c<br>
+++ b/src/mesa/drivers/dri/i965/genX_state_upload.c<br>
@@ -2343,6 +2343,12 @@ genX(upload_cc_viewport)(struct brw_context *brw)<br>
if (ctx->Transform.DepthClampNear && ctx->Transform.DepthClampFar) {<br>
ccv.MinimumDepth = MIN2(vp->Near, vp->Far);<br>
ccv.MaximumDepth = MAX2(vp->Near, vp->Far);<br>
+ } else if (ctx->Transform.DepthClampNear) {<br>
+ ccv.MinimumDepth = MIN2(vp->Near, vp->Far);<br>
+ ccv.MaximumDepth = 0.0;<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Should this be 1.0? If so, probably should add some tests that would catch it.</div><div dir="auto"><br></div><div dir="auto">Cheers,</div><div dir="auto"><br></div><div dir="auto"> -ilia</div></div>