<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> The patch seems fine to me. I also tested it on Intel CI and there were no regressions. Reviewed-by: Samuel Iglesias Gonsálvez <a class="moz-txt-link-rfc2396E" href="mailto:siglesias@igalia.com"><siglesias@igalia.com></a> Thanks, Sam <div class="moz-cite-prefix">On 15/08/18 17:20, <a class="moz-txt-link-abbreviated" href="mailto:asimiklit.work@gmail.com">asimiklit.work@gmail.com</a> wrote: </div> <blockquote type="cite" cite="mid:1534346432-22305-1-git-send-email-asimiklit.work@gmail.com"> <pre wrap="">From: Andrii Simiklit <a class="moz-txt-link-rfc2396E" href="mailto:asimiklit.work@gmail.com"><asimiklit.work@gmail.com></a> When the SVBI Payload Enable is false I guess the register R1.4 which contains the Maximum Streamed Vertex Buffer Index is filled by zero and GS stops to write transform feedback when the transform feedback is not active. Bugzilla: <a class="moz-txt-link-freetext" href="https://bugs.freedesktop.org/show_bug.cgi?id=107579">https://bugs.freedesktop.org/show_bug.cgi?id=107579</a> Signed-off-by: Andrii Simiklit <a class="moz-txt-link-rfc2396E" href="mailto:andrii.simiklit@globallogic.com"><andrii.simiklit@globallogic.com></a> --- src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index ea5ad55..0f82500 100644 --- a/src/mesa/drivers/dri/i965/genX_state_upload.c +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw) #if GEN_GEN < 7 gs.SOStatisticsEnable = true; if (gs_prog->info.has_transform_feedback_varyings) - gs.SVBIPayloadEnable = true; + gs.SVBIPayloadEnable = _mesa_is_xfb_active_and_unpaused(ctx); /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are enabled as it * was previously done for gen6. </pre> </blockquote> </body> </html>