<div dir="ltr"><div dir="ltr"><div dir="ltr"><div>Hi all,</div><div><br></div><div>Could somebody push it if it seems good for all?</div><div><br></div><div>Regards,</div><div>Andrii.<br></div><div><br><div class="gmail_quote"><div dir="ltr">On Thu, Aug 23, 2018 at 4:53 PM Samuel Iglesias Gonsálvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<p>The patch seems fine to me. I also tested it on Intel CI and
there were no regressions.</p>
<p>Reviewed-by: Samuel Iglesias Gonsálvez <a class="gmail-m_8921927488160221503moz-txt-link-rfc2396E" href="mailto:siglesias@igalia.com" target="_blank"><siglesias@igalia.com></a></p>
Thanks,<br>
<br>
Sam<br>
<br>
<div class="gmail-m_8921927488160221503moz-cite-prefix">On 15/08/18 17:20,
<a class="gmail-m_8921927488160221503moz-txt-link-abbreviated" href="mailto:asimiklit.work@gmail.com" target="_blank">asimiklit.work@gmail.com</a> wrote:<br>
</div>
<blockquote type="cite">
<pre>From: Andrii Simiklit <a class="gmail-m_8921927488160221503moz-txt-link-rfc2396E" href="mailto:asimiklit.work@gmail.com" target="_blank"><asimiklit.work@gmail.com></a>
When the SVBI Payload Enable is false I guess the register R1.4
which contains the Maximum Streamed Vertex Buffer Index is filled by zero
and GS stops to write transform feedback when the transform feedback
is not active.
Bugzilla: <a class="gmail-m_8921927488160221503moz-txt-link-freetext" href="https://bugs.freedesktop.org/show_bug.cgi?id=107579" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=107579</a>
Signed-off-by: Andrii Simiklit <a class="gmail-m_8921927488160221503moz-txt-link-rfc2396E" href="mailto:andrii.simiklit@globallogic.com" target="_blank"><andrii.simiklit@globallogic.com></a>
---
src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c
index ea5ad55..0f82500 100644
--- a/src/mesa/drivers/dri/i965/genX_state_upload.c
+++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
@@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw)
#if GEN_GEN < 7
gs.SOStatisticsEnable = true;
if (gs_prog->info.has_transform_feedback_varyings)
- gs.SVBIPayloadEnable = true;
+ gs.SVBIPayloadEnable = _mesa_is_xfb_active_and_unpaused(ctx);
/* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are enabled as it
* was previously done for gen6.
</pre>
</blockquote>
<br>
</div>
</blockquote></div></div></div></div></div>