<div dir="ltr">Hi<div><br></div><div>If this is prime related I can test it tonight for you</div><div><br></div><div>Cheers</div><div><br></div><div>Mike</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, 11 Sep 2018 at 14:06 Thomas Hellstrom <<a href="mailto:thellstrom@vmware.com">thellstrom@vmware.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On 09/11/2018 02:41 PM, Michel Dänzer wrote:<br>
> Any feedback on this patch? Without negative feedback, I'll push it<br>
> later this week.<br>
Hi, Michel,<br>
<br>
This looks ok to me.<br>
<br>
Reviewed-by: Thomas Hellstrom <<a href="mailto:thellstrom@vmware.com" target="_blank">thellstrom@vmware.com</a>><br>
<br>
/Thomas<br>
<br>
><br>
><br>
> On 2018-09-04 6:22 p.m., Michel Dänzer wrote:<br>
>> From: Michel Dänzer <<a href="mailto:michel.daenzer@amd.com" target="_blank">michel.daenzer@amd.com</a>><br>
>><br>
>> We don't need to wait before drawing to the fake front buffer, as front<br>
>> buffer rendering by definition is allowed to produce artifacts.<br>
>><br>
>> Fixes hangs in some cases when re-using the fake front buffer, due to it<br>
>> still being busy (i.e. in use for presentation).<br>
>><br>
>> Cc: <a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop.org</a><br>
>> Bugzilla: <a href="https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2F106404&data=02%7C01%7Cthellstrom%40vmware.com%7C758cf6c04efd4541578a08d617e3e821%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636722664962505455&sdata=RvqyEylP%2B96KAl6k9H5j7cyx1PW%2B3FFMmtpD0PwiQwU%3D&reserved=0" rel="noreferrer" target="_blank">https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2F106404&data=02%7C01%7Cthellstrom%40vmware.com%7C758cf6c04efd4541578a08d617e3e821%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636722664962505455&sdata=RvqyEylP%2B96KAl6k9H5j7cyx1PW%2B3FFMmtpD0PwiQwU%3D&reserved=0</a><br>
>> Bugzilla: <a href="https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2F107757&data=02%7C01%7Cthellstrom%40vmware.com%7C758cf6c04efd4541578a08d617e3e821%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636722664962505455&sdata=PC8P3cOYWvFLWmb8uorlEHbf8PgdSnznaRprhrCm1BU%3D&reserved=0" rel="noreferrer" target="_blank">https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.freedesktop.org%2F107757&data=02%7C01%7Cthellstrom%40vmware.com%7C758cf6c04efd4541578a08d617e3e821%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636722664962505455&sdata=PC8P3cOYWvFLWmb8uorlEHbf8PgdSnznaRprhrCm1BU%3D&reserved=0</a><br>
>> Signed-off-by: Michel Dänzer <<a href="mailto:michel.daenzer@amd.com" target="_blank">michel.daenzer@amd.com</a>><br>
>> ---<br>
>> src/loader/loader_dri3_helper.c | 4 +++-<br>
>> 1 file changed, 3 insertions(+), 1 deletion(-)<br>
>><br>
>> diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c<br>
>> index 91bad86afd8..6c162553f33 100644<br>
>> --- a/src/loader/loader_dri3_helper.c<br>
>> +++ b/src/loader/loader_dri3_helper.c<br>
>> @@ -1819,7 +1819,9 @@ dri3_get_buffer(__DRIdrawable *driDrawable,<br>
>> buffer = new_buffer;<br>
>> draw->buffers[buf_id] = buffer;<br>
>> }<br>
>> - dri3_fence_await(draw->conn, draw, buffer);<br>
>> +<br>
>> + if (buffer_type == loader_dri3_buffer_back)<br>
>> + dri3_fence_await(draw->conn, draw, buffer);<br>
>> <br>
>> /*<br>
>> * Do we need to preserve the content of a previous buffer?<br>
>><br>
><br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>