<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Wed, Sep 12, 2018 at 6:54 PM Ian Romanick <<a href="mailto:idr@freedesktop.org">idr@freedesktop.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 09/12/2018 03:03 PM, Jason Ekstrand wrote:<br>
> ---<br>
>  src/intel/vulkan/anv_device.c                    | 4 ++--<br>
>  src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 1 -<br>
>  2 files changed, 2 insertions(+), 3 deletions(-)<br>
> <br>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c<br>
> index 1af0eacb681..27fcab1ba9d 100644<br>
> --- a/src/intel/vulkan/anv_device.c<br>
> +++ b/src/intel/vulkan/anv_device.c<br>
> @@ -682,8 +682,8 @@ void anv_DestroyInstance(<br>
>        anv_physical_device_finish(&instance->physicalDevice);<br>
>     }<br>
>  <br>
> -   vk_free(&instance->alloc, instance->app_info.app_name);<br>
> -   vk_free(&instance->alloc, instance->app_info.engine_name);<br>
> +   vk_free(&instance->alloc, (char *)instance->app_info.app_name);<br>
> +   vk_free(&instance->alloc, (char *)instance->app_info.engine_name);<br>
<br>
I'm assuming this is to remove the const decoration?  I usually put the<br>
warnings in the commit message.<br></blockquote><div><br></div><div>Done.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Assuming this is to remove const, this patch is<br></blockquote><div><br></div><div>Yup, that's all.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com" target="_blank">ian.d.romanick@intel.com</a>><br></blockquote><div><br></div><div>Thanks!<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
>  <br>
>     VG(VALGRIND_DESTROY_MEMPOOL(instance));<br>
>  <br>
> diff --git a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c b/src/intel/vulkan/anv_nir_apply_pipeline_layout.c<br>
> index 856101cc2ff..6868288e486 100644<br>
> --- a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c<br>
> +++ b/src/intel/vulkan/anv_nir_apply_pipeline_layout.c<br>
> @@ -516,7 +516,6 @@ anv_nir_apply_pipeline_layout(struct anv_pipeline *pipeline,<br>
>        }<br>
>     }<br>
>  <br>
> -   unsigned image_uniform;<br>
>     if (map->image_count > 0) {<br>
>        assert(map->image_count <= MAX_IMAGES);<br>
>        assert(shader->num_uniforms == prog_data->nr_params * 4);<br>
> <br>
<br>
</blockquote></div></div>