<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - tools_error2aub-error2aub fails to build: error: implicit declaration of function ‘va_start’" href="https://bugs.freedesktop.org/show_bug.cgi?id=108120#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - tools_error2aub-error2aub fails to build: error: implicit declaration of function ‘va_start’" href="https://bugs.freedesktop.org/show_bug.cgi?id=108120">bug 108120</a> from <a class="email" href="mailto:lionel.g.landwerlin@linux.intel.com" title="Lionel Landwerlin <lionel.g.landwerlin@linux.intel.com>"> Lionel Landwerlin</a> <pre>(In reply to Paul Menzel from <a href="show_bug.cgi?id=108120#c3">comment #3</a>) > (In reply to Lionel Landwerlin from <a href="show_bug.cgi?id=108120#c2">comment #2</a>) > > Sent <a href="https://patchwork.freedesktop.org/patch/254342/">https://patchwork.freedesktop.org/patch/254342/</a> > > Thanks, I just wanted to upload the same change. Two nitpicks. > > 1. Should the include be inserted lexicographically? > 2. I always prefer to have the error message in the commit message. > > PS: I am not very involved in Mesa, but isn’t there a build tester, which > should have caught that error? (Also, why did nobody else get it?) Feel free to upload a better change, I'll review and push to master. There are build testers. Not quite sure why it wasn't caught... The only explanation I could think of is that we have different build option (we usually build a large set of drivers, not just intel ones) and that somehow pulls in a header file already including stdarg.h.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>