<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Mon, Oct 8, 2018 at 4:06 PM Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl">bas@basnieuwenhuizen.nl</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Oct 8, 2018 at 2:39 PM Samuel Pitoiset<br>
<<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>> wrote:<br>
><br>
> R32G32B32 are weird formats and we are only going to support<br>
> some basic operations for now.<br>
><br>
> Signed-off-by: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>><br>
> ---<br>
>  src/amd/vulkan/radv_formats.c | 14 ++++++++++++++<br>
>  1 file changed, 14 insertions(+)<br>
><br>
> diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c<br>
> index ad06c9e996..a7aa819e2b 100644<br>
> --- a/src/amd/vulkan/radv_formats.c<br>
> +++ b/src/amd/vulkan/radv_formats.c<br>
> @@ -1091,6 +1091,20 @@ static VkResult radv_get_image_format_properties(struct radv_physical_device *ph<br>
>                 sampleCounts |= VK_SAMPLE_COUNT_2_BIT | VK_SAMPLE_COUNT_4_BIT | VK_SAMPLE_COUNT_8_BIT;<br>
>         }<br>
><br>
> +       if (info->tiling == VK_IMAGE_TILING_LINEAR &&<br>
> +           (info->format == VK_FORMAT_R32G32B32_SFLOAT ||<br>
> +            info->format == VK_FORMAT_R32G32B32_SINT ||<br>
> +            info->format == VK_FORMAT_R32G32B32_UINT)) {<br>
Maybe just check if the blocksize is not a power of two?<br></blockquote><div><br></div><div>Probably better if you don't support 24 or 48-bit formats.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Either way, this patch  is<br>
<br>
Reviewed-by: Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl" target="_blank">bas@basnieuwenhuizen.nl</a>><br>
> +               /* R32G32B32 is a weird format and the driver currently only<br>
> +                * supports the barely minimum.<br>
> +                * TODO: Implement more if we really need to.<br>
> +                */<br>
> +               if (info->type == VK_IMAGE_TYPE_3D)<br>
> +                       goto unsupported;<br>
> +               maxArraySize = 1;<br>
> +               maxMipLevels = 1;<br>
> +       }<br>
> +<br>
>         if (info->usage & VK_IMAGE_USAGE_SAMPLED_BIT) {<br>
>                 if (!(format_feature_flags & VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT)) {<br>
>                         goto unsupported;<br>
> --<br>
> 2.19.1<br>
><br>
> _______________________________________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div>