<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Wed, Oct 10, 2018 at 9:47 AM Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Oh dear...<br>
<br>
Reviewed-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>><br>
<br>
Eric, Jason : Could it be the wsi CTS test you've seen locking up forever?<br></blockquote><div><br></div><div>I don't think so.  It blocks in a different place.  In any case, good catch!</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 05/10/2018 01:00, Dave Airlie wrote:<br>
> From: Dave Airlie <<a href="mailto:airlied@redhat.com" target="_blank">airlied@redhat.com</a>><br>
><br>
> Not going to matter, but be consistent.<br>
><br>
> Found by coverity<br>
> ---<br>
>   src/intel/vulkan/anv_allocator.c | 1 +<br>
>   1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c<br>
> index f62d48ae3fe..67f2f73aa11 100644<br>
> --- a/src/intel/vulkan/anv_allocator.c<br>
> +++ b/src/intel/vulkan/anv_allocator.c<br>
> @@ -1358,6 +1358,7 @@ anv_bo_cache_import(struct anv_device *device,<br>
>         if ((new_flags & EXEC_OBJECT_PINNED) &&<br>
>             (bo->bo.flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS) !=<br>
>             (bo_flags & EXEC_OBJECT_SUPPORTS_48B_ADDRESS)) {<br>
> +         pthread_mutex_unlock(&cache->mutex);<br>
>            return vk_errorf(device->instance, NULL,<br>
>                             VK_ERROR_INVALID_EXTERNAL_HANDLE,<br>
>                             "The same BO was imported on two different heaps");<br>
<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div>