<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression" href="https://bugs.freedesktop.org/show_bug.cgi?id=92552#c12">Comment # 12</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression" href="https://bugs.freedesktop.org/show_bug.cgi?id=92552">bug 92552</a> from <a class="email" href="mailto:andrey.simiklit@gmail.com" title="asimiklit <andrey.simiklit@gmail.com>"> asimiklit</a> <pre>(In reply to Ian Romanick from <a href="show_bug.cgi?id=92552#c9">comment #9</a>) > Comment on <a href="attachment.cgi?id=119006" name="attach_119006" title="egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS">attachment 119006</a> <a href="attachment.cgi?id=119006&action=edit" title="egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS">[details]</a> <a href='page.cgi?id=splinter.html&bug=92552&attachment=119006'>[review]</a> [review] > egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS > > Review of <a href="attachment.cgi?id=119006" name="attach_119006" title="egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS">attachment 119006</a> <a href="attachment.cgi?id=119006&action=edit" title="egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS">[details]</a> <a href='page.cgi?id=splinter.html&bug=92552&attachment=119006'>[review]</a> [review]: > ----------------------------------------------------------------- > > There are a few things wrong with this patch. First, you can't check the > version when you see EGL_CONTEXT_FLAGS in the attribs list because the > application could specify the requested version after flags. This should > not generate an error: > > EGL_CONTEXT_FLAGS, EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR, > EGL_CONTEXT_CLIENT_VERSION, 3, > 0 > > Second, it is not correct to generate EGL_BAD_MATCH for > EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR when > EGL_EXT_create_context_robustness is not supported. Think of it this way... > if we deleted all support and knowledge of > EGL_EXT_create_context_robustness, what error would be generated? Default > case in the switch statement says EGL_BAD_ATTRIBUTE. I suggest to improve this test in the following way: <a href="https://patchwork.freedesktop.org/patch/256081/">https://patchwork.freedesktop.org/patch/256081/</a> (In reply to Vinson Lee from <a href="show_bug.cgi?id=92552#c11">comment #11</a>) > mesa: 1e8435ce0cce671024ebf9c5465ea8bdcb563b69 (master 11.3.0-devel) > This regression is still present. The possible mesa fix was suggested: <a href="https://patchwork.freedesktop.org/patch/256063/">https://patchwork.freedesktop.org/patch/256063/</a></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>