<div dir="ltr"><div>And what size would that be on Wayland?  I've opened a spec bug about this and we'll talk about it on the SI call this week.  This entrypoint seems extraordinarily half-baked to me.  I don't see how it makes any sense outside of VK_KHR_display or windows full-screen exclusive.<br></div><div><br></div><div>--Jason<br></div><div><br><div class="gmail_quote"><div dir="ltr">On Mon, Oct 15, 2018 at 10:21 AM Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    <div class="m_-3439635859652838080moz-cite-prefix">Argh :(</div>
    <div class="m_-3439635859652838080moz-cite-prefix"><br>
    </div>
    <div class="m_-3439635859652838080moz-cite-prefix">Shouldn't we at least return the size
      of the surface?<br>
    </div>
    <div class="m_-3439635859652838080moz-cite-prefix"><br>
    </div>
    <div class="m_-3439635859652838080moz-cite-prefix">On 15/10/2018 16:08, Jason Ekstrand
      wrote:<br>
    </div>
    <blockquote type="cite">
      
      <div dir="ltr">It's explicitly for a multi-device case where each
        device presents to part of the screen.  Since we don't do that,
        I'm not sure what we're supposed to do.<br>
        <div><br>
          <div class="gmail_quote">
            <div dir="ltr">On Mon, Oct 15, 2018 at 9:14 AM Lionel
              Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>>
              wrote:<br>
            </div>
            <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I'm
              guessing we should plugged that into the number of screen
              on bare <br>
              DRM for example, which each screen native size reported in
              pRects.<br>
              <br>
              On 15/10/2018 04:47, Jason Ekstrand wrote:<br>
              > Not really sure what we're supposed to do with this
              one but we should do<br>
              > something.<br>
              > ---<br>
              >   src/intel/vulkan/anv_wsi.c | 11 +++++++++++<br>
              >   1 file changed, 11 insertions(+)<br>
              ><br>
              > diff --git a/src/intel/vulkan/anv_wsi.c
              b/src/intel/vulkan/anv_wsi.c<br>
              > index 5ed1d711689..4f3f3fc57af 100644<br>
              > --- a/src/intel/vulkan/anv_wsi.c<br>
              > +++ b/src/intel/vulkan/anv_wsi.c<br>
              > @@ -294,3 +294,14 @@ VkResult
              anv_GetDeviceGroupSurfacePresentModesKHR(<br>
              >   <br>
              >      return VK_SUCCESS;<br>
              >   }<br>
              > +<br>
              > +VkResult anv_GetPhysicalDevicePresentRectanglesKHR(<br>
              > +    VkPhysicalDevice                           
              physicalDevice,<br>
              > +    VkSurfaceKHR                               
              surface,<br>
              > +    uint32_t*                                 
               pRectCount,<br>
              > +    VkRect2D*                                 
               pRects)<br>
              > +{<br>
              > +   /* TODO: What should I be doing here? */<br>
              > +   *pRectCount = 0;<br>
              > +   return VK_SUCCESS;<br>
              > +}<br>
            </blockquote>
          </div>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
  </div>

</blockquote></div></div></div>