<div dir="ltr"><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></div><div><br></div><div>Marek</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 18, 2018 at 10:13 AM Connor Abbott <<a href="mailto:cwabbott0@gmail.com">cwabbott0@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The comment was wrong, since the loop above casts to a type with the<br>
correct bitsize already.<br>
<br>
Fixes: 7e7ee82698247d8f93fe37775b99f4838b0247dd ("ac: add support for 16bit buffer loads")<br>
---<br>
src/amd/common/ac_nir_to_llvm.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c<br>
index 402cf2d6655..ee75e2890dd 100644<br>
--- a/src/amd/common/ac_nir_to_llvm.c<br>
+++ b/src/amd/common/ac_nir_to_llvm.c<br>
@@ -1685,8 +1685,8 @@ static LLVMValueRef visit_load_buffer(struct ac_nir_context *ctx,<br>
};<br>
<br>
if (num_bytes > 16 && num_components == 3) {<br>
- /* we end up with a v4f32 and v2f32 but shuffle fails on that */<br>
- results[1] = ac_build_expand_to_vec4(&ctx->ac, results[1], 2);<br>
+ /* we end up with a v2i64 and i64 but shuffle fails on that */<br>
+ results[1] = ac_build_expand(&ctx->ac, results[1], 1, 2);<br>
}<br>
<br>
LLVMValueRef swizzle = LLVMConstVector(masks, num_components);<br>
-- <br>
2.17.2<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>