<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Mon, Oct 15, 2018 at 6:35 PM Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com" target="_blank">jason.ekstrand@intel.com</a>><br>
<br>
They're not required to be the same as the access flag on the image<br>
unit. For hardware that does shader image lowering based on the<br>
qualifier (Intel), it may be required for state setup.<br>
---<br>
src/gallium/include/pipe/p_state.h | 1 +<br>
src/mesa/state_tracker/st_atom_image.c | 27 ++++++++++++++++++++++----<br>
src/mesa/state_tracker/st_cb_texture.c | 2 +-<br>
src/mesa/state_tracker/st_texture.c | 2 +-<br>
src/mesa/state_tracker/st_texture.h | 5 +++--<br>
5 files changed, 29 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h<br>
index a58d91fb3dd..331417b1d7f 100644<br>
--- a/src/gallium/include/pipe/p_state.h<br>
+++ b/src/gallium/include/pipe/p_state.h<br>
@@ -485,6 +485,7 @@ struct pipe_image_view<br>
struct pipe_resource *resource; /**< resource into which this is a view */<br>
enum pipe_format format; /**< typed PIPE_FORMAT_x */<br>
unsigned access; /**< PIPE_IMAGE_ACCESS_x */<br>
+ unsigned shader_access; /**< PIPE_IMAGE_ACCESS_x */<br></blockquote><div><br></div><div>Can you use uint16_t for both access masks? Other than that:</div><div><br></div><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></div><div><br></div><div>Marek</div></div></div>