<div dir="auto"><div><div class="gmail_quote"><div dir="ltr">wt., 30 paź 2018, 06:08 <<a href="mailto:Mathias.Froehlich@gmx.net">Mathias.Froehlich@gmx.net</a>>:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Mathias Fröhlich <<a href="mailto:mathias.froehlich@web.de" target="_blank" rel="noreferrer">mathias.froehlich@web.de</a>><br>
<br>
On finishing a display list playback the VBO_SAFE_FALLBACK bit<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">s/SAFE/SAVE/g (here and in the title)</div><div dir="auto"><br></div><div dir="auto">Regards,</div><div dir="auto">Gustaw Smolarczyk</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
is still kept in vbo_save_context::replay_flags. But examining<br>
replay_flags and the display list flags that feed this value<br>
the corresponding bit is never set these days anymore.<br>
So, since it is nowhere set or checked, we can safely remove it.<br>
<br>
Signed-off-by: Mathias Fröhlich <<a href="mailto:Mathias.Froehlich@web.de" target="_blank" rel="noreferrer">Mathias.Froehlich@web.de</a>><br>
---<br>
src/mesa/vbo/vbo_save.h | 2 --<br>
src/mesa/vbo/vbo_save_api.c | 8 ++------<br>
2 files changed, 2 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/src/mesa/vbo/vbo_save.h b/src/mesa/vbo/vbo_save.h<br>
index 37f883e9de..d00700166e 100644<br>
--- a/src/mesa/vbo/vbo_save.h<br>
+++ b/src/mesa/vbo/vbo_save.h<br>
@@ -140,8 +140,6 @@ _vbo_save_get_vertex_count(const struct vbo_save_vertex_list *node)<br>
#define VBO_SAVE_PRIM_WEAK 0x40<br>
#define VBO_SAVE_PRIM_NO_CURRENT_UPDATE 0x80<br>
<br>
-#define VBO_SAVE_FALLBACK 0x10000000<br>
-<br>
struct vbo_save_vertex_store {<br>
struct gl_buffer_object *bufferobj;<br>
fi_type *buffer_map;<br>
diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c<br>
index d5b43d0684..975ba46c8e 100644<br>
--- a/src/mesa/vbo/vbo_save_api.c<br>
+++ b/src/mesa/vbo/vbo_save_api.c<br>
@@ -1804,12 +1804,8 @@ vbo_save_EndCallList(struct gl_context *ctx)<br>
{<br>
struct vbo_save_context *save = &vbo_context(ctx)->save;<br>
<br>
- if (ctx->ListState.CallDepth == 1) {<br>
- /* This is correct: want to keep only the VBO_SAVE_FALLBACK<br>
- * flag, if it is set:<br>
- */<br>
- save->replay_flags &= VBO_SAVE_FALLBACK;<br>
- }<br>
+ if (ctx->ListState.CallDepth == 1)<br>
+ save->replay_flags = 0;<br>
}<br>
<br>
<br>
-- <br>
2.17.2<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank" rel="noreferrer">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div></div>