<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:samuel.pitoiset@gmail.com" title="Samuel Pitoiset <samuel.pitoiset@gmail.com>"> <span class="fn">Samuel Pitoiset</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [DXVK] Dauntless Helmets rendering incorrectly on Vega, works in AMDVLK"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108105">bug 108105</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEEDINFO
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [DXVK] Dauntless Helmets rendering incorrectly on Vega, works in AMDVLK"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108105#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [DXVK] Dauntless Helmets rendering incorrectly on Vega, works in AMDVLK"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108105">bug 108105</a>
from <span class="vcard"><a class="email" href="mailto:samuel.pitoiset@gmail.com" title="Samuel Pitoiset <samuel.pitoiset@gmail.com>"> <span class="fn">Samuel Pitoiset</span></a>
</span></b>
<pre>Now fixed.
commit 91533e99d40c335134a635deaee79c726bb618f0
Author: Nicolai Haehnle <<a href="mailto:nhaehnle@gmail.com">nhaehnle@gmail.com</a>>
Date: Wed Oct 31 13:26:48 2018 +0000
AMDGPU: Remove PHI loop condition optimization
Summary:
The optimization to early break out of loops if all threads are dead was
never fully implemented.
But the PHI node analyzing is actually causing a number of problems, so
remove all the extra code for it.
(This does actually regress code quality in a few places because it
ends up relying more heavily on phi's of i1, which we don't do a
great job with. However, since it fixes real bugs in the wild, we
should take this change. I have some prototype changes to improve
i1 lowering in general -- not just for control flow -- which should
help recover the code quality, I just need to make those changes
fit for general consumption. -- Nicolai)
Change-Id: I6fc6c6c8961857ac6009fcfb9f7e5e48dc23fbb1
Patch-by: Christian König <<a href="mailto:christian.koenig@amd.com">christian.koenig@amd.com</a>>
Reviewers: arsenm, rampitec, tpr
Subscribers: kzhuravl, jvesely, wdng, yaxunl, dstuttard, t-tye,
llvm-commits
Differential Revision: <a href="https://reviews.llvm.org/D53359">https://reviews.llvm.org/D53359</a>
git-svn-id: <a href="https://llvm.org/svn/llvm-project/llvm/trunk@345718">https://llvm.org/svn/llvm-project/llvm/trunk@345718</a>
91177308-0d34-0410-b5e6-96231b3b80d8</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>