<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Wed, Oct 31, 2018 at 9:34 AM Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
On 31/10/2018 14:20, Jason Ekstrand wrote:<br>
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">
<div>Toni,</div>
<div><br>
</div>
<div>I'm a bit curious where you're going with this. I
started on a similar project a couple of years ago:</div>
<div><br>
</div>
<div><a href="https://gitlab.freedesktop.org/jekstrand/mesa/commits/wip/genxml-engines" target="_blank">https://gitlab.freedesktop.org/jekstrand/mesa/commits/wip/genxml-engines</a></div>
<div><br>
</div>
<div>Mine took a different (not necessarily better) approach
of surrounding the instructions in an <engine> tag.
I'm not sure if that's any better or worse than an
attribute.</div>
</div>
</div>
</blockquote>
<p><br>
</p>
<p>I suggested the attribute because it would avoid duplication of
some MI instructions.<br>
</p>
</div></blockquote><div><br></div><div>That makes sense. We could do something like engines="a,b,c,d" if we wanted to specify more than one but not all. I guess that makes sense.</div><div><br></div><div>--Jason</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">
<div><br>
</div>
<div>At the time, I was planning to port over the blitter code
to genxml and get aubinator decoding blit streams. I canned
the project because there are few enough differences in
hardware generations for the blitter to be worth the
re-compilation and I had better things to do. I've always
thought it would be good to support other engines for no
other reason than to make aubinator for blits. It would
also likely be useful to have if we wanted to start doing
media in mesa for some reason. What's your motivation? I
ask because I can't really have an opinion on the approach
unless I know where it's headed.<br>
</div>
<div><br>
</div>
<div>--Jason<br>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Wed, Oct 31, 2018 at 8:12 AM Toni Lönnberg
<<a href="mailto:toni.lonnberg@intel.com" target="_blank">toni.lonnberg@intel.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">These
patches add an engine parameter to the instructions defined in
the genxml<br>
files so that they can be distinguished when sending them to
different engines.<br>
By default, an instruction is defined to be used by all
engines and is defined<br>
for a specific engine by adding the parameter "engine" to the
definition.<br>
Currently the supported engines are "render", "video" and
"blitter".<br>
<br>
v2:<br>
<br>
* gen_engine enum removed and replaced with use of
drm_i915_gem_engine_class<br>
<br>
* The current engine being used is now saved in the decoder
context and is not<br>
being passed through gen_print_batch().<br>
<br>
* Split the genxml changes into multiple patches<br>
<br>
Toni Lönnberg (13):<br>
intel/decoder: tools: gen_engine to
drm_i915_gem_engine_class<br>
intel/decoder: Engine parameter for instructions<br>
intel/decoder: tools: Use engine for decoding batch
instructions<br>
intel/genxml: Add engine definition to render engine
instructions<br>
(gen4)<br>
intel/genxml: Add engine definition to render engine
instructions<br>
(gen45)<br>
intel/genxml: Add engine definition to render engine
instructions<br>
(gen5)<br>
intel/genxml: Add engine definition to render engine
instructions<br>
(gen6)<br>
intel/genxml: Add engine definition to render engine
instructions<br>
(gen7)<br>
intel/genxml: Add engine definition to render engine
instructions<br>
(gen75)<br>
intel/genxml: Add engine definition to render engine
instructions<br>
(gen8)<br>
intel/genxml: Add engine definition to render engine
instructions<br>
(gen9)<br>
intel/genxml: Add engine definition to render engine
instructions<br>
(gen10)<br>
intel/genxml: Add engine definition to render engine
instructions<br>
(gen11)<br>
<br>
src/intel/common/gen_batch_decoder.c | 25 ++-<br>
src/intel/common/gen_decoder.c | 18 +-<br>
src/intel/common/gen_decoder.h | 11 +-<br>
src/intel/genxml/gen10.xml | 206
+++++++++++-----------<br>
src/intel/genxml/gen11.xml | 208
+++++++++++------------<br>
src/intel/genxml/gen4.xml | 36 ++--<br>
src/intel/genxml/gen45.xml | 38 ++---<br>
src/intel/genxml/gen5.xml | 44 ++---<br>
src/intel/genxml/gen6.xml | 94 +++++-----<br>
src/intel/genxml/gen7.xml | 154
++++++++---------<br>
src/intel/genxml/gen75.xml | 184
++++++++++----------<br>
src/intel/genxml/gen8.xml | 202
+++++++++++-----------<br>
src/intel/genxml/gen9.xml | 208
+++++++++++------------<br>
src/intel/tools/aub_read.c | 22 +--<br>
src/intel/tools/aub_read.h | 11 +-<br>
src/intel/tools/aubinator.c | 8 +-<br>
src/intel/tools/aubinator_error_decode.c | 16 ++<br>
17 files changed, 763 insertions(+), 722 deletions(-)<br>
<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote>
</div>
<br>
<fieldset class="m_-5078579529710708101mimeAttachmentHeader"></fieldset>
<pre class="m_-5078579529710708101moz-quote-pre">_______________________________________________
mesa-dev mailing list
<a class="m_-5078579529710708101moz-txt-link-abbreviated" href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a>
<a class="m_-5078579529710708101moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a>
</pre>
</blockquote>
<p><br>
</p>
</div>
</blockquote></div></div>