<div dir="ltr">Hello, Sorry, one more point here. Could I ask you to push it, because I don't have a push rights :-) Thanks a lot, Andrii.</div> <div class="gmail_quote"><div dir="ltr">On Fri, Oct 26, 2018 at 6:09 PM Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 26/10/2018 15:29, <a href="mailto:asimiklit.work@gmail.com" target="_blank">asimiklit.work@gmail.com</a> wrote: > From: Andrii Simiklit <<a href="mailto:andrii.simiklit@globallogic.com" target="_blank">andrii.simiklit@globallogic.com</a>> > > Some memory and file descriptors are not freed/closed. > > v2: fixed case where we skipped the 'aub' variable initialization > > Signed-off-by: Andrii Simiklit <<a href="mailto:andrii.simiklit@globallogic.com" target="_blank">andrii.simiklit@globallogic.com</a>> Still : Reviewed-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>> Thanks! > --- > src/intel/tools/error2aub.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/src/intel/tools/error2aub.c b/src/intel/tools/error2aub.c > index 8a23d5ef1e..2b850ce885 100644 > --- a/src/intel/tools/error2aub.c > +++ b/src/intel/tools/error2aub.c > @@ -326,6 +326,16 @@ main(int argc, char *argv[]) > > aub_write_exec(&aub, batch_addr, aub_gtt_size(&aub), I915_EXEC_RENDER); > > + free(out_filename); > + free(line); > + if(err_file) { > + fclose(err_file); > + } > + if(aub.file) { > + aub_file_finish(&aub); > + } else if(aub_file) { > + fclose(aub_file); > + } > return EXIT_SUCCESS; > } > _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div>