<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:samuel.pitoiset@gmail.com" title="Samuel Pitoiset <samuel.pitoiset@gmail.com>"> <span class="fn">Samuel Pitoiset</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [radv] [regression,bisected]: LLVM 8.0 breaks lighting in Mass Effect Andromeda"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108611">bug 108611</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Summary</td>
<td>radv: LLVM 8.0 breaks lighting in Mass Effect Andromeda
</td>
<td>[radv] [regression,bisected]: LLVM 8.0 breaks lighting in Mass Effect Andromeda
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [radv] [regression,bisected]: LLVM 8.0 breaks lighting in Mass Effect Andromeda"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108611#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [radv] [regression,bisected]: LLVM 8.0 breaks lighting in Mass Effect Andromeda"
href="https://bugs.freedesktop.org/show_bug.cgi?id=108611">bug 108611</a>
from <span class="vcard"><a class="email" href="mailto:samuel.pitoiset@gmail.com" title="Samuel Pitoiset <samuel.pitoiset@gmail.com>"> <span class="fn">Samuel Pitoiset</span></a>
</span></b>
<pre>Introduced by the following LLVM commit:
cc436fd26637b0629b95fd8e60fde61cec4b421f is the first bad commit
commit cc436fd26637b0629b95fd8e60fde61cec4b421f
Author: Nicolai Haehnle <<a href="mailto:nhaehnle@gmail.com">nhaehnle@gmail.com</a>>
Date: Wed Oct 17 15:37:30 2018 +0000
AMDGPU: Divergence-driven selection of scalar buffer load intrinsics
Summary:
Moving SMRD to VMEM in SIFixSGPRCopies is rather bad for performance if
the load is really uniform. So select the scalar load intrinsics directly
to either VMEM or SMRD buffer loads based on divergence analysis.
If an offset happens to end up in a VGPR -- either because a floating
point calculation was involved, or due to other remaining deficiencies
in SIFixSGPRCopies -- we use v_readfirstlane.
There is some unrelated churn in tests since we now select MUBUF offsets
in a unified way with non-scalar buffer loads.
Change-Id: I170e6816323beb1348677b358c9d380865cd1a19
Reviewers: arsenm, alex-t, rampitec, tpr
Subscribers: kzhuravl, jvesely, wdng, yaxunl, dstuttard, t-tye,
llvm-commits
Differential Revision: <a href="https://reviews.llvm.org/D53283">https://reviews.llvm.org/D53283</a>
git-svn-id: <a href="https://llvm.org/svn/llvm-project/llvm/trunk@344696">https://llvm.org/svn/llvm-project/llvm/trunk@344696</a>
91177308-0d34-0410-b5e6-96231b3b80d8</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>