<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Pushed to master. Thanks Andrey!<br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">On 31/10/2018 11:48, andrey simiklit
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAHfu=g+cdxcfYCKXfBCEiHvzovUgBXxEOJ4P-vV42r8XDbPXxQ@mail.gmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div dir="ltr">Hello,<br>
<br>
Sorry, one more point here.<br>
Could I ask you to push it, because I don't have a push rights
:-)<br>
<br>
Thanks a lot,<br>
Andrii.</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Fri, Oct 26, 2018 at 6:09 PM Lionel Landwerlin
<<a href="mailto:lionel.g.landwerlin@intel.com"
moz-do-not-send="true">lionel.g.landwerlin@intel.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">On
26/10/2018 15:29, <a href="mailto:asimiklit.work@gmail.com"
target="_blank" moz-do-not-send="true">asimiklit.work@gmail.com</a>
wrote:<br>
> From: Andrii Simiklit <<a
href="mailto:andrii.simiklit@globallogic.com"
target="_blank" moz-do-not-send="true">andrii.simiklit@globallogic.com</a>><br>
><br>
> Some memory and file descriptors are not freed/closed.<br>
><br>
> v2: fixed case where we skipped the 'aub' variable
initialization<br>
><br>
> Signed-off-by: Andrii Simiklit <<a
href="mailto:andrii.simiklit@globallogic.com"
target="_blank" moz-do-not-send="true">andrii.simiklit@globallogic.com</a>><br>
<br>
<br>
Still :<br>
<br>
Reviewed-by: Lionel Landwerlin <<a
href="mailto:lionel.g.landwerlin@intel.com" target="_blank"
moz-do-not-send="true">lionel.g.landwerlin@intel.com</a>><br>
<br>
<br>
Thanks!<br>
<br>
<br>
> ---<br>
> src/intel/tools/error2aub.c | 10 ++++++++++<br>
> 1 file changed, 10 insertions(+)<br>
><br>
> diff --git a/src/intel/tools/error2aub.c
b/src/intel/tools/error2aub.c<br>
> index 8a23d5ef1e..2b850ce885 100644<br>
> --- a/src/intel/tools/error2aub.c<br>
> +++ b/src/intel/tools/error2aub.c<br>
> @@ -326,6 +326,16 @@ main(int argc, char *argv[])<br>
> <br>
> aub_write_exec(&aub, batch_addr,
aub_gtt_size(&aub), I915_EXEC_RENDER);<br>
> <br>
> + free(out_filename);<br>
> + free(line);<br>
> + if(err_file) {<br>
> + fclose(err_file);<br>
> + }<br>
> + if(aub.file) {<br>
> + aub_file_finish(&aub);<br>
> + } else if(aub_file) {<br>
> + fclose(aub_file);<br>
> + }<br>
> return EXIT_SUCCESS;<br>
> }<br>
> <br>
<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org"
target="_blank" moz-do-not-send="true">mesa-dev@lists.freedesktop.org</a><br>
<a
href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote>
</div>
</blockquote>
<p><br>
</p>
</body>
</html>