<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>Hello,</div><div><br></div><div>Any updates here?</div><div><br></div><div>I think that I missed tag:</div><div>Reported-by: Ian Romanick <<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></div><div>Here: <a href="https://bugzilla.freedesktop.org/show_bug.cgi?id=92552#c9" target="_blank">https://bugzilla.freedesktop.org/show_bug.cgi?id=92552#c9</a></div><div><br></div>The patch for the test which will check it:<br><a href="https://patchwork.freedesktop.org/patch/256432/">https://patchwork.freedesktop.org/patch/256432/</a></div><div dir="ltr"><br></div><div>Thanks,</div><div>Andrii.<br></div><div dir="ltr"><div><span class="gmail-bz_comment_user"><span class="gmail-vcard"><span class="gmail-fn"></span></span></span></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 11, 2018 at 2:12 PM <<a href="mailto:asimiklit.work@gmail.com">asimiklit.work@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">From: Andrii Simiklit <<a href="mailto:andrii.simiklit@globallogic.com" target="_blank">andrii.simiklit@globallogic.com</a>><br>
<br>
The EGL_KHR_create_context spec says:<br>
"If an OpenGL context is requested and the values for attributes<br>
EGL_CONTEXT_MAJOR_VERSION_KHR and EGL_CONTEXT_MINOR_VERSION_KHR,<br>
when considered together with the value for attribute<br>
EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR, specify an OpenGL<br>
version and feature set that are not defined, than an<br>
EGL_BAD_MATCH error is generated."<br>
<br>
This case will be correctly handled<br>
a bit below after a 'for' loop when we<br>
remove this handling.<br>
<br>
Fixes: 11cabc45b712 "egl: rework handling EGL_CONTEXT_FLAGS"<br>
Bugzilla: <a href="https://bugzilla.freedesktop.org/show_bug.cgi?id=92552" rel="noreferrer" target="_blank">https://bugzilla.freedesktop.org/show_bug.cgi?id=92552</a><br>
Signed-off-by: Andrii Simiklit <<a href="mailto:andrii.simiklit@globallogic.com" target="_blank">andrii.simiklit@globallogic.com</a>><br>
---<br>
src/egl/main/eglcontext.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c<br>
index ecc546e113..44a4469a97 100644<br>
--- a/src/egl/main/eglcontext.c<br>
+++ b/src/egl/main/eglcontext.c<br>
@@ -179,7 +179,7 @@ _eglParseContextAttribList(_EGLContext *ctx, _EGLDisplay *dpy,<br>
* will generate an error."<br>
*/<br>
if ((val & EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR) &&<br>
- (api != EGL_OPENGL_API || ctx->ClientMajorVersion < 3)) {<br>
+ api != EGL_OPENGL_API) {<br>
err = EGL_BAD_ATTRIBUTE;<br>
break;<br>
}<br>
-- <br>
2.17.1<br>
<br>
</blockquote></div></div></div></div></div>