<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr">On Thu, 15 Nov 2018, 10:11 Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com">samuel.pitoiset@gmail.com</a> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">After doing a bunch of benchmarks, primitive binning helps<br>
some games like The Talos Principle (+5%) or Serious Sam 2017<br>
(+3%). For other titles, either it doesn't change anything or<br>
it hurts very few (less than 1%).<br>
<br>
This only affects GFX9.<br>
<br>
Signed-off-by: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank" rel="noreferrer">samuel.pitoiset@gmail.com</a>><br>
---<br>
src/amd/vulkan/radv_debug.h | 5 ++---<br>
src/amd/vulkan/radv_device.c | 3 +--<br>
2 files changed, 3 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/src/amd/vulkan/radv_debug.h b/src/amd/vulkan/radv_debug.h<br>
index 397d567961..01712bd22c 100644<br>
--- a/src/amd/vulkan/radv_debug.h<br>
+++ b/src/amd/vulkan/radv_debug.h<br>
@@ -57,9 +57,8 @@ enum {<br>
RADV_PERFTEST_NO_BATCHCHAIN = 0x1,<br>
RADV_PERFTEST_SISCHED = 0x2,<br>
RADV_PERFTEST_LOCAL_BOS = 0x4,<br>
- RADV_PERFTEST_BINNING = 0x8,<br>
- RADV_PERFTEST_OUT_OF_ORDER = 0x10,<br>
- RADV_PERFTEST_DCC_MSAA = 0x20,<br>
+ RADV_PERFTEST_OUT_OF_ORDER = 0x8,<br>
+ RADV_PERFTEST_DCC_MSAA = 0x10,<br>
};<br>
<br>
bool<br>
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c<br>
index b2078975a8..617886b8d8 100644<br>
--- a/src/amd/vulkan/radv_device.c<br>
+++ b/src/amd/vulkan/radv_device.c<br>
@@ -466,7 +466,6 @@ static const struct debug_control radv_perftest_options[] = {<br>
{"nobatchchain", RADV_PERFTEST_NO_BATCHCHAIN},<br>
{"sisched", RADV_PERFTEST_SISCHED},<br>
{"localbos", RADV_PERFTEST_LOCAL_BOS},<br>
- {"binning", RADV_PERFTEST_BINNING},<br>
{"dccmsaa", RADV_PERFTEST_DCC_MSAA},<br>
{NULL, 0}<br>
};<br>
@@ -1635,7 +1634,7 @@ VkResult radv_CreateDevice(<br>
}<br>
<br>
device->pbb_allowed = device->physical_device->rad_info.chip_class >= GFX9 &&<br>
- ((device->instance->perftest_flags & RADV_PERFTEST_BINNING) ||<br>
+ (!(device->instance->debug_flags & RADV_DEBUG_NOBINNING) ||<br>
device->physical_device->rad_info.family == CHIP_RAVEN ||<br>
device->physical_device->rad_info.family == CHIP_RAVEN2);<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">You can remove the Raven check since it is enabled by default.</div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto">With that</div><div dir="auto"><br></div><div dir="auto">Reviewed-by: Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl">bas@basnieuwenhuizen.nl</a>></div><div dir="auto"><br></div><div dir="auto">for the series.</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
-- <br>
2.19.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank" rel="noreferrer">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div></div>