<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Sun, Nov 18, 2018 at 9:57 PM Dave Airlie <<a href="mailto:airlied@gmail.com">airlied@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Dave Airlie <<a href="mailto:airlied@redhat.com" target="_blank">airlied@redhat.com</a>><br>
<br>
Check if the base ends up with no variable, and continue<br>
if we see that case outside the loop.<br>
---<br>
 src/compiler/nir/nir_lower_indirect_derefs.c | 4 ++++<br>
 1 file changed, 4 insertions(+)<br>
<br>
diff --git a/src/compiler/nir/nir_lower_indirect_derefs.c b/src/compiler/nir/nir_lower_indirect_derefs.c<br>
index 897a0620872..3d6452ac847 100644<br>
--- a/src/compiler/nir/nir_lower_indirect_derefs.c<br>
+++ b/src/compiler/nir/nir_lower_indirect_derefs.c<br>
@@ -141,8 +141,12 @@ lower_indirect_derefs_block(nir_block *block, nir_builder *b,<br>
             has_indirect = true;<br>
<br>
          base = nir_deref_instr_parent(base);<br>
+         if (base == NULL)<br>
+            break;<br>
       }<br>
<br>
+      if (base == NULL)<br>
+         continue;<br>
       if (!has_indirect)<br></blockquote><div><br></div><div>My version of this patch did "while (base &&" and "if (!base || !has_indirect)" which makes the code a bit smaller.  Doesn't matter much.  Either way,</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
          continue;<br>
<br>
-- <br>
2.17.2<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div>