<div dir="ltr"><div>See what Gustaw said. Other than that:</div><div><br></div><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></div><div><br></div><div>Marek<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 21, 2018 at 10:21 AM Nicolai Hähnle <<a href="mailto:nhaehnle@gmail.com">nhaehnle@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Nicolai Hähnle <<a href="mailto:nicolai.haehnle@amd.com" target="_blank">nicolai.haehnle@amd.com</a>><br>
<br>
Our choices here are simply redundant as long as sin.flags is set<br>
correctly.<br>
--<br>
This is the change I was talking about.<br>
---<br>
src/amd/common/ac_surface.c | 10 ----------<br>
1 file changed, 10 deletions(-)<br>
<br>
diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c<br>
index edd710a968c..ad2cb585c9d 100644<br>
--- a/src/amd/common/ac_surface.c<br>
+++ b/src/amd/common/ac_surface.c<br>
@@ -1057,30 +1057,20 @@ gfx9_get_preferred_swizzle_mode(ADDR_HANDLE addrlib,<br>
sin.forbiddenBlock.var = 1; /* don't allow the variable-sized swizzle modes */<br>
sin.forbiddenBlock.linear = 1; /* don't allow linear swizzle modes */<br>
sin.bpp = in->bpp;<br>
sin.width = in->width;<br>
sin.height = in->height;<br>
sin.numSlices = in->numSlices;<br>
sin.numMipLevels = in->numMipLevels;<br>
sin.numSamples = in->numSamples;<br>
sin.numFrags = in->numFrags;<br>
<br>
- if (flags & RADEON_SURF_SCANOUT) {<br>
- sin.preferredSwSet.sw_D = 1;<br>
- /* Raven only allows S for displayable surfaces with < 64 bpp, so<br>
- * allow it as fallback */<br>
- sin.preferredSwSet.sw_S = 1;<br>
- } else if (in->flags.depth || in->flags.stencil || is_fmask)<br>
- sin.preferredSwSet.sw_Z = 1;<br>
- else<br>
- sin.preferredSwSet.sw_S = 1;<br>
-<br>
if (is_fmask) {<br>
sin.flags.display = 0;<br>
sin.flags.color = 0;<br>
sin.flags.fmask = 1;<br>
}<br>
<br>
ret = Addr2GetPreferredSurfaceSetting(addrlib, &sin, &sout);<br>
if (ret != ADDR_OK)<br>
return ret;<br>
<br>
-- <br>
2.19.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>