<div dir="ltr"><div>We don't support storage on any WSI image formats but that shouldn't be an actual problem.</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 20, 2018 at 3:30 PM Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl">bas@basnieuwenhuizen.nl</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Since apps also have to follow the ImageFormatProperties query,<br>
we can disallow formats that don't allow image stores (for AMD<br>
that would be SRGB formats).<br>
<br>
Note that this only affects anything if the app actually decides<br>
to use the flag.<br>
<br>
Had someone ask for this on IRC and at least on the AMD side we<br>
can support it.<br>
<br>
CC: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>><br>
---<br>
src/vulkan/wsi/wsi_common_display.c | 1 +<br>
src/vulkan/wsi/wsi_common_wayland.c | 1 +<br>
src/vulkan/wsi/wsi_common_x11.c | 1 +<br>
3 files changed, 3 insertions(+)<br>
<br>
diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c<br>
index fd0d30ad80c..edfb166fa69 100644<br>
--- a/src/vulkan/wsi/wsi_common_display.c<br>
+++ b/src/vulkan/wsi/wsi_common_display.c<br>
@@ -834,6 +834,7 @@ wsi_display_surface_get_capabilities(VkIcdSurfaceBase *surface_base,<br>
VK_IMAGE_USAGE_TRANSFER_SRC_BIT |<br>
VK_IMAGE_USAGE_SAMPLED_BIT |<br>
VK_IMAGE_USAGE_TRANSFER_DST_BIT |<br>
+ VK_IMAGE_USAGE_STORAGE_BIT |<br>
VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;<br>
<br>
return VK_SUCCESS;<br>
diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c<br>
index 3d3a60167bf..c0132566ead 100644<br>
--- a/src/vulkan/wsi/wsi_common_wayland.c<br>
+++ b/src/vulkan/wsi/wsi_common_wayland.c<br>
@@ -508,6 +508,7 @@ wsi_wl_surface_get_capabilities(VkIcdSurfaceBase *surface,<br>
VK_IMAGE_USAGE_TRANSFER_SRC_BIT |<br>
VK_IMAGE_USAGE_SAMPLED_BIT |<br>
VK_IMAGE_USAGE_TRANSFER_DST_BIT |<br>
+ VK_IMAGE_USAGE_STORAGE_BIT |<br>
VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;<br>
<br>
return VK_SUCCESS;<br>
diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c<br>
index c740726fe54..6146c8f3da8 100644<br>
--- a/src/vulkan/wsi/wsi_common_x11.c<br>
+++ b/src/vulkan/wsi/wsi_common_x11.c<br>
@@ -515,6 +515,7 @@ x11_surface_get_capabilities(VkIcdSurfaceBase *icd_surface,<br>
VK_IMAGE_USAGE_TRANSFER_SRC_BIT |<br>
VK_IMAGE_USAGE_SAMPLED_BIT |<br>
VK_IMAGE_USAGE_TRANSFER_DST_BIT |<br>
+ VK_IMAGE_USAGE_STORAGE_BIT |<br>
VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT;<br>
<br>
return VK_SUCCESS;<br>
-- <br>
2.19.1<br>
<br>
</blockquote></div></div></div>