<div dir="ltr"><div>I haven't checked the HW docs but</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 4, 2018 at 1:18 AM Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Extended math desn't support half-float on these generations.<br>
---<br>
src/intel/compiler/brw_nir.c | 13 ++++++++++++-<br>
1 file changed, 12 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c<br>
index e0027f5179c..0b3094724c4 100644<br>
--- a/src/intel/compiler/brw_nir.c<br>
+++ b/src/intel/compiler/brw_nir.c<br>
@@ -614,6 +614,8 @@ lower_bit_size_callback(const nir_alu_instr *alu, UNUSED void *data)<br>
if (alu->dest.dest.ssa.bit_size != 16)<br>
return 0;<br>
<br>
+ const struct brw_compiler *compiler = (const struct brw_compiler *) data;<br>
+<br>
switch (alu->op) {<br>
case nir_op_idiv:<br>
case nir_op_imod:<br>
@@ -626,6 +628,15 @@ lower_bit_size_callback(const nir_alu_instr *alu, UNUSED void *data)<br>
case nir_op_fround_even:<br>
case nir_op_ftrunc:<br>
return 32;<br>
+ case nir_op_frcp:<br>
+ case nir_op_frsq:<br>
+ case nir_op_fsqrt:<br>
+ case nir_op_fpow:<br>
+ case nir_op_fexp2:<br>
+ case nir_op_flog2:<br>
+ case nir_op_fsin:<br>
+ case nir_op_fcos:<br>
+ return compiler->devinfo->gen < 9 ? 32 : 0;<br>
default:<br>
return 0;<br>
}<br>
@@ -692,7 +703,7 @@ brw_preprocess_nir(const struct brw_compiler *compiler, nir_shader *nir)<br>
OPT(nir_opt_large_constants, NULL, 32);<br>
}<br>
<br>
- OPT(nir_lower_bit_size, lower_bit_size_callback, NULL);<br>
+ OPT(nir_lower_bit_size, lower_bit_size_callback, (void *)compiler);<br>
<br>
if (is_scalar) {<br>
OPT(nir_lower_load_const_to_scalar);<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>