<div dir="ltr"><div dir="ltr">This'll have to be rebased on dca6cd9ce6510 but otherwise looks fine. I've been a bit annoyed by this myself.</div><div dir="ltr"><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>></div><div><br></div><div>Incidentally, this could also be lowered in NIR.... Not sure if we want to but there it is.<br></div><div dir="ltr"><div><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 4, 2018 at 1:18 AM Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Since we handle booleans as integers this makes more sense.<br>
---<br>
src/intel/compiler/brw_fs_nir.cpp | 10 +++++-----<br>
1 file changed, 5 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp<br>
index 9f3d3bf9762..6c765fc2661 100644<br>
--- a/src/intel/compiler/brw_fs_nir.cpp<br>
+++ b/src/intel/compiler/brw_fs_nir.cpp<br>
@@ -801,11 +801,6 @@ fs_visitor::nir_emit_alu(const fs_builder &bld, nir_alu_instr *instr)<br>
inst->saturate = instr->dest.saturate;<br>
break;<br>
<br>
- case nir_op_b2i:<br>
- case nir_op_b2f:<br>
- op[0].type = BRW_REGISTER_TYPE_D;<br>
- op[0].negate = !op[0].negate;<br>
- /* fallthrough */<br>
case nir_op_f2f64:<br>
case nir_op_f2i64:<br>
case nir_op_f2u64:<br>
@@ -850,6 +845,11 @@ fs_visitor::nir_emit_alu(const fs_builder &bld, nir_alu_instr *instr)<br>
inst->saturate = instr->dest.saturate;<br>
break;<br>
<br>
+ case nir_op_b2i:<br>
+ case nir_op_b2f:<br>
+ op[0].type = BRW_REGISTER_TYPE_D;<br>
+ op[0].negate = !op[0].negate;<br>
+ /* fallthrough */<br>
case nir_op_i2f64:<br>
case nir_op_i2i64:<br>
case nir_op_u2f64:<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div></div></div>