<div dir="ltr"><div dir="ltr"><br><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 10, 2018 at 7:05 AM Erik Faye-Lund <<a href="mailto:erik.faye-lund@collabora.com" target="_blank">erik.faye-lund@collabora.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">When I made sure that half-float texture-filtering was required for ES3,<br>
I didn't realize that virgl doesn't report support for this correctly.<br>
This regressed the GLES version available on top of several drivers,<br>
including i965 from 3.2 to 2.0.<br>
<br>
This is going to need protocol changes to fix properly, so let's just<br>
restore the previous behavior by enabling floating-point filtering<br>
unconditionally for now.<br>
<br>
Signed-off-by: Erik Faye-Lund <<a href="mailto:erik.faye-lund@collabora.com" target="_blank">erik.faye-lund@collabora.com</a>><br>
Fixes: fcf9fcee3c8 "mesa/main: do not require float-texture filtering for es3"<br>
---<br>
src/gallium/drivers/virgl/virgl_screen.c | 5 +++--<br>
1 file changed, 3 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/gallium/drivers/virgl/virgl_screen.c b/src/gallium/drivers/virgl/virgl_screen.c<br>
index 3d6424e39f6..b32c061491c 100644<br>
--- a/src/gallium/drivers/virgl/virgl_screen.c<br>
+++ b/src/gallium/drivers/virgl/virgl_screen.c<br>
@@ -255,6 +255,9 @@ virgl_get_param(struct pipe_screen *screen, enum pipe_cap param)<br>
return vscreen->caps.caps.v2.max_combined_atomic_counters;<br>
case PIPE_CAP_MAX_COMBINED_HW_ATOMIC_COUNTER_BUFFERS:<br>
return vscreen->caps.caps.v2.max_combined_atomic_counter_buffers;<br>
+ case PIPE_CAP_TEXTURE_FLOAT_LINEAR:<br>
+ case PIPE_CAP_TEXTURE_HALF_FLOAT_LINEAR:<br>
+ return 1; /* TODO: need to introduce a hw-cap for this */<br>
case PIPE_CAP_TEXTURE_GATHER_SM5:<br>
case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:<br>
case PIPE_CAP_FAKE_SW_MSAA:<br>
@@ -267,8 +270,6 @@ virgl_get_param(struct pipe_screen *screen, enum pipe_cap param)<br>
case PIPE_CAP_MULTISAMPLE_Z_RESOLVE:<br>
case PIPE_CAP_RESOURCE_FROM_USER_MEMORY:<br>
case PIPE_CAP_DEVICE_RESET_STATUS_QUERY:<br>
- case PIPE_CAP_TEXTURE_FLOAT_LINEAR:<br>
- case PIPE_CAP_TEXTURE_HALF_FLOAT_LINEAR:<br>
case PIPE_CAP_DEPTH_BOUNDS_TEST:<br>
case PIPE_CAP_SHAREABLE_SHADERS:<br>
case PIPE_CAP_CLEAR_TEXTURE:<br></blockquote><div><br></div><div><br></div><div>Reviewed-by: Gurchetan Singh <a href="mailto:gurchetansingh@chromium.org">gurchetansingh@chromium.org</a><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
-- <br>
2.19.2<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div></div>