<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 18, 2018, 9:57 PM Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com">samuel.pitoiset@gmail.com</a> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We don't ever want to do the fmask lookup on a atomic or<br>
store, the fmask should have been decompressed if the<br>
surface has been moved to IMAGE_LAYOUT.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Clarify the description to be a *storage* image layout?</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Original patch by Dave Airlie.<br>
<br>
Signed-off-by: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank" rel="noreferrer">samuel.pitoiset@gmail.com</a>><br>
---<br>
src/amd/common/ac_nir_to_llvm.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c<br>
index 225c930d896..0f57dc7eeb4 100644<br>
--- a/src/amd/common/ac_nir_to_llvm.c<br>
+++ b/src/amd/common/ac_nir_to_llvm.c<br>
@@ -2243,7 +2243,7 @@ static void get_image_coords(struct ac_nir_context *ctx,<br>
bool gfx9_1d = ctx->ac.chip_class >= GFX9 && dim == GLSL_SAMPLER_DIM_1D;<br>
count = image_type_to_components_count(dim, is_array);<br>
<br>
- if (is_ms) {<br>
+ if (is_ms && instr->intrinsic == nir_intrinsic_image_deref_load) {<br>
LLVMValueRef fmask_load_address[3];<br>
int chan;<br>
<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank" rel="noreferrer">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div></div>