<div dir="ltr"><div>Nice. For the series:</div><div><br></div><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></div><div><br></div><div>Marek<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 17, 2018 at 8:18 PM Timothy Arceri <<a href="mailto:tarceri@itsqueeze.com">tarceri@itsqueeze.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">---<br>
src/gallium/drivers/radeonsi/si_shader_nir.c | 10 ++--------<br>
1 file changed, 2 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c<br>
index b81bea00b8..931d41245d 100644<br>
--- a/src/gallium/drivers/radeonsi/si_shader_nir.c<br>
+++ b/src/gallium/drivers/radeonsi/si_shader_nir.c<br>
@@ -285,14 +285,8 @@ void si_nir_scan_tess_ctrl(const struct nir_shader *nir,<br>
if (nir->info.stage != MESA_SHADER_TESS_CTRL)<br>
return;<br>
<br>
- /* Initial value = true. Here the pass will accumulate results from<br>
- * multiple segments surrounded by barriers. If tess factors aren't<br>
- * written at all, it's a shader bug and we don't care if this will be<br>
- * true.<br>
- */<br>
- out->tessfactors_are_def_in_all_invocs = true;<br>
-<br>
- /* TODO: Implement scanning of tess factors, see tgsi backend. */<br>
+ out->tessfactors_are_def_in_all_invocs =<br>
+ ac_are_tessfactors_def_in_all_invocs(nir);<br>
}<br>
<br>
void si_nir_scan_shader(const struct nir_shader *nir,<br>
-- <br>
2.19.2<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>