<div dir="ltr">ACK<br></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 8, 2019 at 12:27 PM Caio Marcelo de Oliveira Filho <<a href="mailto:caio.oliveira@intel.com">caio.oliveira@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Initialize the variable with NULL. Fixes the following<br>
<br>
In file included from ../src/compiler/nir/nir_lower_io.c:34:<br>
../src/compiler/nir/nir_lower_io.c: In function ‘nir_lower_explicit_io’:<br>
../src/compiler/nir/nir.h:668:11: warning: ‘addr’ may be used uninitialized in this function [-Wmaybe-uninitialized]<br>
return src;<br>
^~~<br>
../src/compiler/nir/nir_lower_io.c:735:17: note: ‘addr’ was declared here<br>
nir_ssa_def *addr;<br>
^~~~<br>
<br>
v2: Avoid using a 'default' case so we get help from the compiler when<br>
new deref types are added. (Lionel)<br>
---<br>
src/compiler/nir/nir_lower_io.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/nir_lower_io.c<br>
index bcbfebdfa3b..44af76de599 100644<br>
--- a/src/compiler/nir/nir_lower_io.c<br>
+++ b/src/compiler/nir/nir_lower_io.c<br>
@@ -732,7 +732,7 @@ lower_explicit_io_deref(nir_builder *b, nir_deref_instr *deref,<br>
assert(deref->parent.is_ssa);<br>
nir_ssa_def *parent_addr = deref->parent.ssa;<br>
<br>
- nir_ssa_def *addr;<br>
+ nir_ssa_def *addr = NULL;<br>
assert(deref->dest.is_ssa);<br>
switch (deref->deref_type) {<br>
case nir_deref_type_var:<br>
-- <br>
2.20.0<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>