<div dir="ltr">Pushed.<br></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jan 10, 2019 at 10:35 AM Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>><br></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jan 10, 2019 at 5:57 AM Erik Faye-Lund <<a href="mailto:erik.faye-lund@collabora.com" target="_blank">erik.faye-lund@collabora.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Reviewed-by: Erik Faye-Lund <<a href="mailto:erik.faye-lund@collabora.com" target="_blank">erik.faye-lund@collabora.com</a>><br>
<br>
On Thu, 2019-01-10 at 11:23 +0000, Rhys Perry wrote:<br>
> Fixes: 393b59e0772e7bf0426bdf61c740752c4e09dde1<br>
>     ('nir: Rework nir_lower_constant_initializers() to handle<br>
> functions')<br>
> ---<br>
>  src/compiler/nir/nir_lower_constant_initializers.c | 4 ++--<br>
>  1 file changed, 2 insertions(+), 2 deletions(-)<br>
> <br>
> diff --git a/src/compiler/nir/nir_lower_constant_initializers.c<br>
> b/src/compiler/nir/nir_lower_constant_initializers.c<br>
> index cbee59b1f30..959d1eabfca 100644<br>
> --- a/src/compiler/nir/nir_lower_constant_initializers.c<br>
> +++ b/src/compiler/nir/nir_lower_constant_initializers.c<br>
> @@ -104,10 +104,10 @@ nir_lower_constant_initializers(nir_shader<br>
> *shader, nir_variable_mode modes)<br>
>           impl_progress |= lower_const_initializer(&builder, &shader-<br>
> >outputs);<br>
>  <br>
>        if ((modes & nir_var_private) && function->is_entrypoint)<br>
> -         impl_progress |= lower_const_initializer(&builder, &shader-<br>
> >outputs);<br>
> +         impl_progress |= lower_const_initializer(&builder, &shader-<br>
> >globals);<br>
>  <br>
>        if ((modes & nir_var_system_value) && function->is_entrypoint)<br>
> -         impl_progress |= lower_const_initializer(&builder, &shader-<br>
> >outputs);<br>
> +         impl_progress |= lower_const_initializer(&builder, &shader-<br>
> >system_values);<br>
>  <br>
>        if (modes & nir_var_function)<br>
>           impl_progress |= lower_const_initializer(&builder,<br>
> &function->impl->locals);<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>
</blockquote></div>