<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>I mostly agree with your thoughts below. Will add some additional
comments inline.<br>
</p>
<div class="moz-cite-prefix">On 11/1/19 18:05, Jason Ekstrand wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAOFGe970QMMW8pHznSfQnVNX=BhuQP5dEo4ckzTvmY6udojQhA@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div>I'm putting my own thoughts in a reply for some
reason. Here's what I've seen.</div>
<div><br>
</div>
<div> 1. I really like GitLab "discussions". It provides a
very good way for both the author and the reviewers to
keep track of what review comments have been dealt with
and what comments are still outstanding.</div>
</div>
</div>
</div>
</blockquote>
<p><br>
</p>
<p>Yes, I agree that the general discussion for a series has
improved. But ...<br>
</p>
<blockquote type="cite"
cite="mid:CAOFGe970QMMW8pHznSfQnVNX=BhuQP5dEo4ckzTvmY6udojQhA@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><br>
</div>
<div> 2. GitLab is currently missing a good way to comment
on commit messages which makes giving review tags rather
painful. There is a GitLab issue opened about this: <a
href="https://gitlab.com/gitlab-org/gitlab-ce/issues/38602"
moz-do-not-send="true">https://gitlab.com/gitlab-org/gitlab-ce/issues/38602</a></div>
<div><br>
</div>
<div> 3. GitLab has a bug regarding per-commit comments
where they tend to get lost while you're looking at the
commit itself: <a
href="https://gitlab.com/gitlab-org/gitlab-ce/issues/53175"
moz-do-not-send="true">https://gitlab.com/gitlab-org/gitlab-ce/issues/53175</a></div>
</div>
</div>
</div>
</blockquote>
<p><br>
</p>
<p>... as you mention here, there are some per-commit bugs. This
makes per-commit discussion and tagging (as you mention below)
harder, so the general discussion gets somewhat messy with
individual commit messages. And in addition to what your comment
here, I miss the possibility to add an annotate section on
individual commits. For example, the usual annotate section "I
have this, but I'm not happy of X due Y, what do you think", or in
other words, a placeholder for starting a discussion/debate for
such commit. I guess that if those bugs are fixed, it would be
just doing the push, and then adding those "annotate sections" on
the commits. <br>
</p>
<blockquote type="cite"
cite="mid:CAOFGe970QMMW8pHznSfQnVNX=BhuQP5dEo4ckzTvmY6udojQhA@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><br>
</div>
<div> 4. At least two of those merge requests were small bug
fixes by brand new contributors who I've never seen on the
mailing list.</div>
<div><br>
</div>
<div> 5. There's no way with gitlab for Reviewed-by tags to
get automatically applied as part of the merging process.
This makes merging a bit more manual than it needs to be
but is really no worse than it was before.</div>
</div>
</div>
</div>
</blockquote>
<p><br>
</p>
<p>Well, I would say that it slightly worse. For small series, it is
true that I manually added the Rb when I got a review. But for big
series, when it got reviewed, I used patchwork to get back the
series, but with the Rb in place. <br>
</p>
<blockquote type="cite"
cite="mid:CAOFGe970QMMW8pHznSfQnVNX=BhuQP5dEo4ckzTvmY6udojQhA@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div><br>
</div>
<div>Ok, there you have my thoughts. I'd be happy to hear
others.</div>
<div><br>
</div>
<div>--Jason<br>
</div>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Fri, Jan 11, 2019 at 10:57 AM Jason Ekstrand
<<a href="mailto:jason@jlekstrand.net"
moz-do-not-send="true">jason@jlekstrand.net</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div>All,</div>
<div><br>
</div>
<div>The mesa project has now hit 100 merge requests (36 are
still open). I (and I'm sure others) would be curious to
hear people's initial thoughts on the process. What's
working well? What's not working? Is it total fail and
should we go back to mailing lists?<br>
</div>
<div><br>
</div>
<div>--Jason<br>
</div>
</div>
</blockquote>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
mesa-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a>
</pre>
</blockquote>
</body>
</html>