<div dir="ltr"><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></div><div><br></div><div>Marek<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Sun, Jan 13, 2019 at 1:57 PM Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Currently we were only returning it for BGRA8. But it makes sense to<br>
return it for all the BGR[AX] variants. This was discovered when<br>
figuring out why wlroots was sending a RGBX instead of BGRX image when<br>
screenshotting.<br>
<br>
Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>><br>
---<br>
<br>
Not sure that this can really matter for performance -- I guess in some<br>
cases it means we can memcpy a mapped RB. But we might also fall off<br>
some optimized imageBuffer pbo download path. On average, probably<br>
"meh", but seems more consistent.<br>
<br>
src/mesa/main/framebuffer.c | 5 +++++<br>
1 file changed, 5 insertions(+)<br>
<br>
diff --git a/src/mesa/main/framebuffer.c b/src/mesa/main/framebuffer.c<br>
index 10dd2fde446..09059a11cbd 100644<br>
--- a/src/mesa/main/framebuffer.c<br>
+++ b/src/mesa/main/framebuffer.c<br>
@@ -850,6 +850,11 @@ _mesa_get_color_read_format(struct gl_context *ctx,<br>
case MESA_FORMAT_RGBA_UINT8:<br>
return GL_RGBA_INTEGER;<br>
case MESA_FORMAT_B8G8R8A8_UNORM:<br>
+ case MESA_FORMAT_B8G8R8X8_UNORM:<br>
+ case MESA_FORMAT_B5G5R5A1_UNORM:<br>
+ case MESA_FORMAT_B5G5R5X1_UNORM:<br>
+ case MESA_FORMAT_B4G4R4A4_UNORM:<br>
+ case MESA_FORMAT_B4G4R4X4_UNORM:<br>
return GL_BGRA;<br>
case MESA_FORMAT_B5G6R5_UNORM:<br>
case MESA_FORMAT_R11G11B10_FLOAT:<br>
-- <br>
2.19.2<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>